Icons missing from extension trees with resource uris (#152039)

alexr00 · web-flow · commit 30d9c6cd9483 · 2022-06-14T12:55:41.000+02:00
Fixes #152036
diff --git a/src/vs/workbench/browser/parts/views/treeView.ts b/src/vs/workbench/browser/parts/views/treeView.ts
@@ -1084,7 +1084,7 @@ class TreeRenderer extends Disposable implements ITreeRenderer<ITreeItem, FuzzyS
 	private shouldHideResourceLabelIcon(iconUrl: URI | undefined, icon: ThemeIcon | undefined): boolean {
 		// We always hide the resource label in favor of the iconUrl when it's provided.
 		// When `ThemeIcon` is provided, we hide the resource label icon in favor of it only if it's a not a file icon.
-		return !!iconUrl || !this.isFileKindThemeIcon(icon);
+		return (!!iconUrl || (!!icon && !this.isFileKindThemeIcon(icon)));
 	}
 
 	private shouldShowThemeIcon(hasResource: boolean, icon: ThemeIcon | undefined): icon is ThemeIcon {

Original file line number	Diff line number	Diff line change
`@@ -1084,7 +1084,7 @@ class TreeRenderer extends Disposable implements ITreeRenderer<ITreeItem, FuzzyS`
`1084`	`1084`	`private shouldHideResourceLabelIcon(iconUrl: URI \| undefined, icon: ThemeIcon \| undefined): boolean {`
`1085`	`1085`	`// We always hide the resource label in favor of the iconUrl when it's provided.`
`1086`	`1086`	// When `ThemeIcon` is provided, we hide the resource label icon in favor of it only if it's a not a file icon.
`1087`		`- return !!iconUrl \|\| !this.isFileKindThemeIcon(icon);`
	`1087`	`+ return (!!iconUrl \|\| (!!icon && !this.isFileKindThemeIcon(icon)));`
`1088`	`1088`	`}`
`1089`	`1089`
`1090`	`1090`	`private shouldShowThemeIcon(hasResource: boolean, icon: ThemeIcon \| undefined): icon is ThemeIcon {`