Merge pull request #34 from microsoft/robo/fix_handle_leak

Tyriar · web-flow · commit fa43487f87f7 · 2021-10-13T08:58:19.000-07:00
fix: process handle leak
diff --git a/src/process.cc b/src/process.cc
@@ -55,6 +55,8 @@ void GetProcessMemoryUsage(ProcessInfo process_info[1024], uint32_t* process_cou
   if (GetProcessMemoryInfo(hProcess, &pmc, sizeof(pmc))) {
     process_info[*process_count].memory = (DWORD)pmc.WorkingSetSize;
   }
+
+  CloseHandle(hProcess);
 }
 
 // Per documentation, it is not recommended to add or subtract values from the FILETIME

Original file line number	Diff line number	Diff line change
`@@ -55,6 +55,8 @@ void GetProcessMemoryUsage(ProcessInfo process_info[1024], uint32_t* process_cou`
`55`	`55`	`if (GetProcessMemoryInfo(hProcess, &pmc, sizeof(pmc))) {`
`56`	`56`	`process_info[*process_count].memory = (DWORD)pmc.WorkingSetSize;`
`57`	`57`	`}`
	`58`	`+`
	`59`	`+ CloseHandle(hProcess);`
`58`	`60`	`}`
`59`	`61`
`60`	`62`	`// Per documentation, it is not recommended to add or subtract values from the FILETIME`