Button uses wrong background on hover with light HC theme

[daviddossett]

[daviddossett]

It appears this is related to this behavior:

vscode-webview-ui-toolkit/src/utilities/theme/applyTheme.ts

Lines 56 to 60 in 3ba7054

	if (
	value.length === 0 &&
	toolkitToken.name.includes('background')
	) {
	value = 'transparent';

I'm slightly confused why removing this as a sanity check doesn't work since these values are indeed explictly set in VS Code core. Note the hcLight value set here:

https://github.com/microsoft/vscode/blob/6fcf02f29a125db24f67bd9dc43110a02773edf0/src/vs/platform/theme/common/colorRegistry.ts#L269

Is this related to how the tokens are supplied to webviews?

[daviddossett]

VS Code now tells webviews about hc-light so I can pick this up later this week or next.