Skip to content
This repository was archived by the owner on Jan 6, 2025. It is now read-only.

Commit 1ab7c33

Browse files
Update eslint related dependencies and ci pipelines (#526)
Description of changes Updates the following eslint-related packages to latest stable versions: - eslint - eslint-config-prettier - eslint-plugin-import - @typescript-eslint/eslint-plugin - @microsoft/eslint-config-fast-dna Also removes a deprecated rule from .eslintrc.cjs. Also also, updates both GitHub and Azure CI pipelines to use Node v18 (from v14 😅) and removes a no longer used test job.
1 parent fe691ce commit 1ab7c33

File tree

5 files changed

+2527
-2388
lines changed

5 files changed

+2527
-2388
lines changed

.eslintrc.cjs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ module.exports = {
77
'@typescript-eslint/explicit-function-return-type': 'off',
88
'@typescript-eslint/explicit-module-boundary-types': 'off',
99
'@typescript-eslint/no-non-null-assertion': 'off',
10-
'@typescript-eslint/interface-name-prefix': 'off',
1110
},
1211
overrides: [
1312
{

.github/workflows/ci.yml

Lines changed: 2 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -3,24 +3,6 @@ name: toolkit-ci
33
on: pull_request
44

55
jobs:
6-
test:
7-
runs-on: ubuntu-latest
8-
timeout-minutes: 10
9-
steps:
10-
- name: Checkout 🛎️
11-
uses: actions/checkout@v2
12-
13-
- name: Setup Node 💾
14-
uses: actions/setup-node@v2
15-
with:
16-
node-version: '14'
17-
18-
- name: Install Dependencies 📥
19-
run: npm install
20-
21-
- name: Run Tests 🧪
22-
run: npm run test
23-
246
lint:
257
runs-on: ubuntu-latest
268
timeout-minutes: 10
@@ -31,7 +13,7 @@ jobs:
3113
- name: Setup Node 💾
3214
uses: actions/setup-node@v2
3315
with:
34-
node-version: '14'
16+
node-version: '18'
3517

3618
- name: Install Dependencies 📥
3719
run: npm install
@@ -52,7 +34,7 @@ jobs:
5234
- name: Setup Node 💾
5335
uses: actions/setup-node@v2
5436
with:
55-
node-version: '14'
37+
node-version: '18'
5638

5739
- name: Install Dependencies 📥
5840
run: npm install

azure-pipelines.yml

Lines changed: 4 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -41,32 +41,18 @@ stages:
4141
$(Build.SourcesDirectory)/**/*.ts
4242
ErrorLevel: 'warn'
4343

44-
- stage: build_test
45-
displayName: 'Build & Test'
44+
- stage: build_lint
45+
displayName: 'Build & Lint'
4646
pool:
4747
vmImage: 'ubuntu-latest'
4848
jobs:
49-
- job: test
50-
timeoutInMinutes: 10
51-
steps:
52-
- task: NodeTool@0
53-
displayName: 'Setup Node 💾'
54-
inputs:
55-
versionSpec: '14.x'
56-
57-
- script: npm install
58-
displayName: 'Install Dependencies 📥'
59-
60-
- script: npm run test
61-
displayName: 'Run Tests 🧪'
62-
6349
- job: lint
6450
timeoutInMinutes: 10
6551
steps:
6652
- task: NodeTool@0
6753
displayName: 'Setup Node 💾'
6854
inputs:
69-
versionSpec: '14.x'
55+
versionSpec: '18.x'
7056

7157
- script: npm install
7258
displayName: 'Install Dependencies 📥'
@@ -83,7 +69,7 @@ stages:
8369
- task: NodeTool@0
8470
displayName: 'Setup Node 💾'
8571
inputs:
86-
versionSpec: '14.x'
72+
versionSpec: '18.x'
8773

8874
- script: npm install
8975
displayName: 'Install Dependencies 📥'

0 commit comments

Comments
 (0)