Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable signing in vsce using script #986

Merged
merged 9 commits into from
Jun 3, 2024
Merged

enable signing in vsce using script #986

merged 9 commits into from
Jun 3, 2024

Conversation

sandy081
Copy link
Member

@sandy081 sandy081 commented Jun 3, 2024

enable signing in vsce using script

  • add --sign script argument for signing the manifest
  • enable package and publish to sign the package using @vscode/vsce-sign package and sign script

joaomoreno
joaomoreno requested changes Jun 3, 2024
View reviewed changes
src/main.ts Outdated Show resolved Hide resolved
src/package.ts Outdated Show resolved Hide resolved
@sandy081 sandy081 marked this pull request as ready for review June 3, 2024 11:19
@vscodenpa vscodenpa added this to the May 2024 milestone Jun 3, 2024
joaomoreno
joaomoreno reviewed Jun 3, 2024
View reviewed changes
src/package.ts Outdated Show resolved Hide resolved
@sandy081 sandy081 enabled auto-merge June 3, 2024 11:37
@sandy081 sandy081 merged commit f8acdd9 into main Jun 3, 2024
11 checks passed
@sandy081 sandy081 deleted the sandy081/sign branch June 3, 2024 11:39
@kieferrm kieferrm mentioned this pull request Jun 13, 2024
Closed
50 tasks
@X-oss-byte X-oss-byte mentioned this pull request Jun 25, 2024
Open
@sarvex sarvex mentioned this pull request Jun 26, 2024
Open
This was referenced Jun 26, 2024
Closed
Closed
Closed
This was referenced Jun 30, 2024
Merged
Merged
@anandgupta42 anandgupta42 mentioned this pull request Jul 6, 2024
Merged
@X-oss-byte X-oss-byte mentioned this pull request Jul 10, 2024
Open
@sarvex sarvex mentioned this pull request Jul 10, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Jul 11, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Jul 13, 2024
Open
@anandgupta42 anandgupta42 mentioned this pull request Jul 13, 2024
Closed
@X-oss-byte X-oss-byte mentioned this pull request Jul 16, 2024
Open
@anandgupta42 anandgupta42 mentioned this pull request Jul 17, 2024
Merged
@X-oss-byte X-oss-byte mentioned this pull request Jul 17, 2024
Open
This was referenced Jul 17, 2024
Open
Open
This was referenced Jul 22, 2024
Open
Open
Open
This was referenced Jul 29, 2024
Open
Open
@X-oss-byte X-oss-byte mentioned this pull request Aug 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaomoreno joaomoreno joaomoreno approved these changes

Assignees

@sandy081 sandy081

Labels
None yet
Projects
None yet
Milestone
May 2024
Development

Successfully merging this pull request may close these issues.
3 participants
@sandy081 @joaomoreno @vscodenpa