Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devcontainer: confusing SCM view when git is not installed #10188

Open
akosyakov opened this issue Aug 26, 2024 · 2 comments
Open

devcontainer: confusing SCM view when git is not installed #10188

akosyakov opened this issue Aug 26, 2024 · 2 comments
Assignees
Labels
containers Issue in vscode-remote containers

Comments

@akosyakov
Copy link

Version: 1.92.2
Commit: fee1edb8d6d72a0ddff41e5f71a671c23ed924b9
Date: 2024-08-14T17:29:30.058Z
Electron: 30.1.2
ElectronBuildId: 9870757
Chromium: 124.0.6367.243
Node.js: 20.14.0
V8: 12.4.254.20-electron.0
OS: Darwin arm64 23.6.0

Steps to Reproduce:

  1. Start a dev container without git.
  2. VS Code is going to propose how to install Git in SCM view, but for your local machine, not remote container.

Screenshot 2024-08-26 at 11 38 13

Does this issue occur when you try this locally?: Yes/No
Does this issue occur when you try this locally and all extensions are disabled?: Yes/No

@vs-code-engineering vs-code-engineering bot added the containers Issue in vscode-remote containers label Aug 26, 2024
@bamurtaugh
Copy link
Member

cc @lszomoru since I wonder if this would live more in the SCM view logic rather than the Dev Containers extension (and SCM view would look different if it detects it's in a remote environment)

@lszomoru
Copy link
Member

@digitarald, I suspect that we should not be showing the "install" welcome view when connected to a remote.

@lszomoru lszomoru assigned lszomoru and unassigned chrmarti Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
containers Issue in vscode-remote containers
Projects
None yet
Development

No branches or pull requests

7 participants
@digitarald @akosyakov @lszomoru @chrmarti @bamurtaugh and others