Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Do not truncate whitespace for multi-line string" #24096

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

anthonykim1
Copy link

@anthonykim1 anthonykim1 commented Sep 11, 2024

Reverts #23977

Have to revert #23977 with issue: #23743 due to #24069

Will revisit why #23743 is breaking if contained inside other top level (in ast term) code block, and look into how to support #23743 without breaking.

@anthonykim1 anthonykim1 added bug Issue identified by VS Code Team member as probable bug area-repl labels Sep 11, 2024
@anthonykim1 anthonykim1 self-assigned this Sep 11, 2024
@anthonykim1 anthonykim1 marked this pull request as ready for review September 11, 2024 23:02
@vs-code-engineering vs-code-engineering bot added this to the September 2024 milestone Sep 11, 2024
@anthonykim1 anthonykim1 merged commit 6578d9d into main Sep 11, 2024
77 checks passed
@anthonykim1 anthonykim1 deleted the revert-23977-betterNormalize branch September 11, 2024 23:15
anthonykim1 added a commit to anthonykim1/vscode-python that referenced this pull request Sep 11, 2024
…24096)

Reverts microsoft#23977

Have to revert microsoft#23977
with issue: microsoft#23743 due
to microsoft#24069

Will revisit why microsoft#23743
is breaking if contained inside other top level (in ast term) code
block, and look into how to support
microsoft#23743 without
breaking.
anthonykim1 added a commit to anthonykim1/vscode-python that referenced this pull request Sep 12, 2024
…24096)

Reverts microsoft#23977

Have to revert microsoft#23977
with issue: microsoft#23743 due
to microsoft#24069

Will revisit why microsoft#23743
is breaking if contained inside other top level (in ast term) code
block, and look into how to support
microsoft#23743 without
breaking.
anthonykim1 added a commit that referenced this pull request Sep 12, 2024
…24099)

Reverts #23977

Have to revert #23977
with issue: #23743 due
to #24069

Will revisit why #23743
is breaking if contained inside other top level (in ast term) code
block, and look into how to support
#23743 without
breaking.
anthonykim1 added a commit to anthonykim1/vscode-python that referenced this pull request Sep 13, 2024
…24096)

Reverts microsoft#23977

Have to revert microsoft#23977
with issue: microsoft#23743 due
to microsoft#24069

Will revisit why microsoft#23743
is breaking if contained inside other top level (in ast term) code
block, and look into how to support
microsoft#23743 without
breaking.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-repl bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants