Update engine version to match LSP client #24065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@karthiknadig are you okay with this going in? This would be for the hotfix branch? Not sure where you generate hotfixes from. |
|
This is fine. But it should probably also be updated n main. Typically we put fix in main then pull it into branch |
|
Okay I'll rebase it |
rchiodo
force-pushed
the
rchiodo/update_engine_version
branch
from
e952e65
to
3c3616c
Compare
rchiodo
commented
Sep 9, 2024
karthiknadig
approved these changes
Sep 9, 2024
anthonykim1
pushed a commit
to anthonykim1/vscode-python
that referenced
this pull request
Sep 9, 2024
Co-authored-by: Karthik Nadig <kanadig@microsoft.com>
karthiknadig
added a commit
to karthiknadig/vscode-python
that referenced
this pull request
Sep 9, 2024
Co-authored-by: Karthik Nadig <kanadig@microsoft.com>
anthonykim1
pushed a commit
to anthonykim1/vscode-python
that referenced
this pull request
Sep 13, 2024
Co-authored-by: Karthik Nadig <kanadig@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.