Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboard Python to the new localization work #19946

Closed
wants to merge 3 commits into from
Closed

Conversation

TylerLeonhardt
Copy link
Member

Following https://github.com/microsoft/vscode-engineering/wiki/Extensions-Localization

This onboards vscode-python to the new localization API which enables localization for the web.

It's a large PR ... but pretty boring since it's just replacing one syntax with another.

chrmarti
chrmarti previously approved these changes Oct 5, 2022
@TylerLeonhardt TylerLeonhardt added the feature-request Request for new features or functionality label Oct 5, 2022
@karthiknadig
Copy link
Member

@paulacamargo25 I think we may have to move all the strings to localize.ts. That might be the way we will be doing this going forward.

@TylerLeonhardt
Copy link
Member Author

Looks like the extension has some compile issues moving to the latest types. I'm gonna mark this as draft and set it aside for now since there's more to do here.

@TylerLeonhardt TylerLeonhardt marked this pull request as draft October 6, 2022 21:15
@karthiknadig karthiknadig deleted the tyler/new-l10n branch March 1, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants