-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move from yarn to npm #1771
Move from yarn to npm #1771
Conversation
So Travis says it's passing, but if you look at the details every single test failed. https://travis-ci.org/Microsoft/vscode-python/jobs/385379858#L677 suggests there might be a problem. Do you happen to know what's going on, @DonJayamanne ? |
Codecov Report
@@ Coverage Diff @@
## master #1771 +/- ##
==========================================
- Coverage 74.44% 74.05% -0.39%
==========================================
Files 282 282
Lines 13253 13089 -164
Branches 2382 2335 -47
==========================================
- Hits 9866 9693 -173
- Misses 3257 3264 +7
- Partials 130 132 +2
Continue to review full report at Codecov.
|
@brettcannon We'll need to update the dev and standard dependencies together next time. Here's a detailed explanation of the problem:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty much exactly what I figured this change would entail.
If Travis succeeds then this PR is safe to go in, I'll update the CI on VSTS to switch over to npm now. NOTE: I killed the VSTS build, please ignore it for the purpose of this PR.
|
Fixes #1402
This pull request: