Skip to content

ensureTerminal should return Promise<Terminal>  #24106

Open

Description

ensureTerminal should return Promise rather than Promise.
This way we dont have to have the TerminalService class save the state of Terminal.

Could even potentially look at getting rid of TerminalService.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

Labels

area-terminaldebtCovers everything internal: CI, testing, refactoring of the codebase, etc.triage-neededNeeds assignment to the proper sub-team

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions