Put implicit context checkbox behind a setting (#207788)

Author: roblourens

src/vs/workbench/contrib/chat/browser/chat.contribution.ts

@@ -92,7 +92,12 @@ configurationRegistry.registerConfiguration({
 			type: 'number',
 			description: nls.localize('interactiveSession.editor.lineHeight', "Controls the line height in pixels in chat codeblocks. Use 0 to compute the line height from the font size."),
 			default: 0
-		}
+		},
+		'chat.experimental.implicitContext': {
+			type: 'boolean',
+			description: nls.localize('chat.experimental.implicitContext', "Controls whether a checkbox is shown to allow the user to determine which implicit context is included with a chat participant's prompt."),
+			default: false
+		},
 	}
 });
 

src/vs/workbench/contrib/chat/browser/chatContributionServiceImpl.ts

@@ -84,8 +84,8 @@ const chatParticipantExtensionPoint = extensionsRegistry.ExtensionsRegistry.regi
 					markdownDescription: localize('chatParticipantIsDefaultDescription', "**Only** allowed for extensions that have the `defaultChatParticipant` proposal."),
 					type: 'boolean',
 				},
-				defaultImplicitTools: {
-					markdownDescription: 'The names of the tools that are invoked by default',
+				defaultImplicitVariables: {
+					markdownDescription: 'The names of the variables that are invoked by default',
 					type: 'array',
 					items: {
 						type: 'string'

src/vs/workbench/contrib/chat/browser/chatInputPart.ts

@@ -80,6 +80,7 @@ export class ChatInputPart extends Disposable implements IHistoryNavigationWidge
 	private implicitContextContainer!: HTMLElement;
 	private implicitContextLabel!: HTMLElement;
 	private implicitContextCheckbox!: Checkbox;
+	private implicitContextSettingEnabled = false;
 	get implicitContextEnabled() {
 		return this.implicitContextCheckbox.checked;
 	}
@@ -131,10 +132,16 @@ export class ChatInputPart extends Disposable implements IHistoryNavigationWidge
 
 		this.history = new HistoryNavigator([], 5);
 		this._register(this.historyService.onDidClearHistory(() => this.history.clear()));
+
+		this.implicitContextSettingEnabled = this.configurationService.getValue<boolean>('chat.experimental.implicitContext');
 		this._register(this.configurationService.onDidChangeConfiguration(e => {
 			if (e.affectsConfiguration(AccessibilityVerbositySettingId.Chat)) {
 				this.inputEditor.updateOptions({ ariaLabel: this._getAriaLabel() });
 			}
+
+			if (e.affectsConfiguration('chat.experimental.implicitContext')) {
+				this.implicitContextSettingEnabled = this.configurationService.getValue<boolean>('chat.experimental.implicitContext');
+			}
 		}));
 	}
 
@@ -376,7 +383,7 @@ export class ChatInputPart extends Disposable implements IHistoryNavigationWidge
 	}
 
 	setImplicitContextKinds(kinds: string[]) {
-		dom.setVisibility(kinds.length > 0, this.implicitContextContainer);
+		dom.setVisibility(this.implicitContextSettingEnabled && kinds.length > 0, this.implicitContextContainer);
 		this.implicitContextLabel.textContent = localize('use', "Use") + ' ' + kinds.map(k => `#${k}`).join(', ');
 	}
 

src/vs/workbench/contrib/chat/browser/chatWidget.ts

@@ -522,7 +522,11 @@ export class ChatWidget extends Disposable implements IChatWidget {
 		}));
 		this._register(this.inputPart.onDidChangeHeight(() => this.bodyDimension && this.layout(this.bodyDimension.height, this.bodyDimension.width)));
 		this._register(this.inputEditor.onDidChangeModelContent(() => this.updateImplicitContextKinds()));
-		this._register(this.chatAgentService.onDidChangeAgents(() => this.updateImplicitContextKinds()));
+		this._register(this.chatAgentService.onDidChangeAgents(() => {
+			if (this.viewModel) {
+				this.updateImplicitContextKinds();
+			}
+		}));
 	}
 
 	private onDidStyleChange(): void {