Drop pathExistsSync().

Author: ericsnowcurrently

src/client/common/platform/fileSystem.ts

@@ -327,14 +327,6 @@ export class FileSystemUtils implements IFileSystemUtils {
     public async directoryExists(dirname: string): Promise<boolean> {
         return this.pathExists(dirname, FileType.Directory);
     }
-    public pathExistsSync(filename: string): boolean {
-        try {
-            this.raw.statSync(filename);
-        } catch {
-            return false;
-        }
-        return true;
-    }
 
     public async listdir(dirname: string): Promise<[string, FileType][]> {
         try {
@@ -436,6 +428,15 @@ export class FileSystem implements IFileSystem {
         return this.utils.search(globPattern);
     }
 
+    public fileExistsSync(filename: string): boolean {
+        try {
+            this.utils.raw.statSync(filename);
+        } catch {
+            return false;
+        }
+        return true;
+    }
+
     //****************************
     // aliases
 
@@ -463,10 +464,6 @@ export class FileSystem implements IFileSystem {
         return this.utils.raw.copyFile(src, dest);
     }
 
-    public fileExistsSync(filename: string): boolean {
-        return this.utils.pathExistsSync(filename);
-    }
-
     public readFileSync(filename: string): string {
         return this.utils.raw.readTextSync(filename);
     }

src/client/common/platform/types.ts

@@ -139,8 +139,6 @@ export interface IFileSystemUtils {
 
     // Decide if the two filenames are equivalent.
     arePathsSame(path1: string, path2: string): boolean;  // Move to IPathUtils.
-    // Determine if the file or directory exists.
-    pathExistsSync(filename: string): boolean;
 }
 
 // more aliases (to cause less churn)

src/test/common/platform/filesystem.functional.test.ts

@@ -816,22 +816,6 @@ suite('FileSystem Utils', () => {
         });
     });
 
-    suite('pathExistsSync', () => {
-        test('exists', async () => {
-            const filename = await fix.createFile('x/y/z/spam.py');
-
-            const exists = utils.pathExistsSync(filename);
-
-            expect(exists).to.equal(true);
-        });
-
-        test('not found', async () => {
-            const exists = utils.pathExistsSync(DOES_NOT_EXIST);
-
-            expect(exists).to.equal(false);
-        });
-    });
-
     suite('getSubDirectories', () => {
         test('mixed types', async () => {
             const symlinkSource = await fix.createFile('x/info.py');

src/test/common/platform/filesystem.unit.test.ts

@@ -815,30 +815,6 @@ suite('FileSystem Utils', () => {
         });
     });
 
-    suite('pathExistsSync', () => {
-        test('exists', async () => {
-            const filename = 'x/y/z/spam.py';
-            filesystem.setup(f => f.statSync(filename))
-                .returns(() => stat.object);
-
-            const exists = utils.pathExistsSync(filename);
-
-            expect(exists).to.equal(true);
-            verifyAll();
-        });
-
-        test('not found', async () => {
-            const filename = 'x/y/z/spam.py';
-            filesystem.setup(f => f.statSync(filename))
-                .throws(new Error('file not found'));
-
-            const exists = utils.pathExistsSync(filename);
-
-            expect(exists).to.equal(false);
-            verifyAll();
-        });
-    });
-
     suite('getSubDirectories', () => {
         test('mixed types', async () => {
             const dirname = 'x/y/z/spam';