bump node version and python api (#781)

eleanorjboyd · web-flow · commit 4b02c623c18a · 2025-09-05T13:11:25.000-07:00
* bump node version and python api

* update to remove deps greater than in python ext

* update deps

* add install for envs ext

* activate envs ext

* add logging

* .

* ..

* fix dir

* cleanup logging
diff --git a/.github/workflows/pr-check.yml b/.github/workflows/pr-check.yml
@@ -6,11 +6,11 @@ on:
 permissions: {}
 
 env:
-  NODE_VERSION: 18.17.1
+  NODE_VERSION: 22.17.0
   TEST_RESULTS_DIRECTORY: .
   # Force a path with spaces and unicode chars to test extension works in these scenarios
-  special-working-directory: './🐍 🐛'
-  special-working-directory-relative: '🐍 🐛'
+  special-working-directory: './testDir'
+  special-working-directory-relative: 'testDir'
 
 jobs:
   build-vsix:
diff --git a/.github/workflows/push-check.yml b/.github/workflows/push-check.yml
@@ -11,11 +11,11 @@ on:
 permissions: {}
 
 env:
-  NODE_VERSION: 18.17.1
+  NODE_VERSION: 22.17.0
   TEST_RESULTS_DIRECTORY: .
   # Force a path with spaces and unicode chars to test extension works in these scenarios
-  special-working-directory: './🐍 🐛'
-  special-working-directory-relative: '🐍 🐛'
+  special-working-directory: './testDir'
+  special-working-directory-relative: 'testDir'
 
 jobs:
   build-vsix:
diff --git a/build/azure-pipeline.pre-release.yml b/build/azure-pipeline.pre-release.yml
@@ -58,7 +58,7 @@ extends:
     buildSteps:
       - task: NodeTool@0
         inputs:
-          versionSpec: '18.17.1'
+          versionSpec: '22.17.0'
         displayName: Select Node version
 
       - task: UsePythonVersion@0
diff --git a/build/azure-pipeline.stable.yml b/build/azure-pipeline.stable.yml
@@ -53,7 +53,7 @@ extends:
     buildSteps:
       - task: NodeTool@0
         inputs:
-          versionSpec: '18.17.1'
+          versionSpec: '22.17.0'
         displayName: Select Node version
 
       - task: UsePythonVersion@0
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -612,14 +612,14 @@
         "vsce-package": "npx @vscode/vsce package -o python-debugger.vsix"
     },
     "devDependencies": {
-        "@types/chai": "^4.3.4",
-        "@types/chai-as-promised": "^7.1.8",
+        "@types/chai": "^4.1.2",
+        "@types/chai-as-promised": "^7.1.0",
         "@types/fs-extra": "^11.0.4",
         "@types/glob": "^7.2.0",
-        "@types/lodash": "^4.14.191",
-        "@types/mocha": "^10.0.7",
-        "@types/node": "18.x",
-        "@types/semver": "^7.3.13",
+        "@types/lodash": "^4.14.104",
+        "@types/mocha": "^9.1.0",
+        "@types/node": "^22.5.0",
+        "@types/semver": "^5.5.0",
         "@types/sinon": "^10.0.13",
         "@types/vscode": "^1.87.0",
         "@typescript-eslint/eslint-plugin": "^5.62.0",
@@ -638,17 +638,17 @@
         "ts-mockito": "^2.6.1",
         "typemoq": "^2.1.0",
         "typescript": "^5.5.4",
-        "webpack": "^5.87.0",
-        "webpack-cli": "^5.1.4"
+        "webpack": "^5.76.0",
+        "webpack-cli": "^4.9.2"
     },
     "dependencies": {
         "@vscode/debugadapter": "^1.65.0",
         "@vscode/debugprotocol": "^1.65.0",
-        "@vscode/extension-telemetry": "^0.8.5",
-        "@vscode/python-extension": "^1.0.5",
+        "@vscode/extension-telemetry": "^0.8.4",
+        "@vscode/python-extension": "^1.0.6",
         "fs-extra": "^11.2.0",
         "iconv-lite": "^0.6.3",
-        "jsonc-parser": "^3.2.0",
+        "jsonc-parser": "^3.0.0",
         "lodash": "^4.17.21",
         "vscode-languageclient": "^8.0.2"
     }
diff --git a/src/extension/common/python.ts b/src/extension/common/python.ts
@@ -39,7 +39,6 @@ async function activateExtension() {
     console.log('Python extension activated.');
     return extension;
 }
-
 async function activateEnvsExtension() {
     const extension = extensions.getExtension('ms-python.vscode-python-envs');
     if (extension) {
diff --git a/src/test/constants.ts b/src/test/constants.ts
@@ -33,6 +33,8 @@ function isMultiRootTest() {
 export const EXTENSION_ROOT_DIR_FOR_TESTS = path.join(__dirname, '..', '..');
 export const PVSC_EXTENSION_ID_FOR_TESTS = 'ms-python.python';
 
+export const PVSC_ENVS_EXTENSION_ID_FOR_TESTS = 'ms-python.vscode-python-envs';
+
 export const SMOKE_TEST_EXTENSIONS_DIR = path.join(
     EXTENSION_ROOT_DIR_FOR_TESTS,
     'tmp',
diff --git a/src/test/runTest.ts b/src/test/runTest.ts
@@ -2,8 +2,7 @@ import * as cp from 'child_process';
 import * as path from 'path';
 
 import { downloadAndUnzipVSCode, resolveCliArgsFromVSCodeExecutablePath, runTests } from '@vscode/test-electron';
-import { PVSC_EXTENSION_ID_FOR_TESTS } from './constants';
-import { OSType, getOSType } from '../extension/common/platform';
+import { PVSC_ENVS_EXTENSION_ID_FOR_TESTS, PVSC_EXTENSION_ID_FOR_TESTS } from './constants';
 
 async function main() {
     try {
@@ -18,19 +17,49 @@ async function main() {
         const [cliPath, ...args] = resolveCliArgsFromVSCodeExecutablePath(vscodeExecutablePath);
 
         // Use cp.spawn / cp.exec for custom setup
-        if (getOSType() === OSType.Windows) {
-            const exec = path.basename(cliPath);
-            cp.spawnSync(exec, [...args, '--install-extension', PVSC_EXTENSION_ID_FOR_TESTS], {
-                cwd: path.dirname(cliPath),
-                encoding: 'utf-8',
-                stdio: 'inherit',
-            });
+        const isWin = process.platform === 'win32';
+        if (isWin) {
+            try {
+                const installResult = cp.spawnSync(
+                    cliPath,
+                    [...args, '--install-extension', PVSC_EXTENSION_ID_FOR_TESTS, PVSC_ENVS_EXTENSION_ID_FOR_TESTS],
+                    {
+                        cwd: path.dirname(cliPath),
+                        encoding: 'utf8',
+                        stdio: 'inherit',
+                        shell: true,
+                    },
+                );
+                if (installResult.error) {
+                    console.error('Extension installation error:', installResult.error);
+                }
+                if (installResult.status !== 0) {
+                    console.error(`Extension installation failed with exit code: ${installResult.status}`);
+                } else {
+                    console.log('Extension installation succeeded.');
+                }
+            } catch (ex) {
+                console.error('Exception during extension installation:', ex);
+            }
         } else {
-            cp.spawnSync(cliPath, [...args, '--install-extension', PVSC_EXTENSION_ID_FOR_TESTS], {
-                encoding: 'utf-8',
-                stdio: 'inherit',
-            });
+            const installResult = cp.spawnSync(
+                cliPath,
+                [...args, '--install-extension', PVSC_EXTENSION_ID_FOR_TESTS, PVSC_ENVS_EXTENSION_ID_FOR_TESTS],
+                {
+                    encoding: 'utf8',
+                    stdio: 'inherit',
+                },
+            );
+            if (installResult.error) {
+                console.error('Extension installation error:', installResult.error);
+            }
+            if (installResult.status !== 0) {
+                console.error(`Extension installation failed with exit code: ${installResult.status}`);
+            } else {
+                console.log('Extension installation succeeded.');
+            }
         }
+        console.log('Extensions installed, ready to run tests.');
 
         // Run the extension test
         await runTests({

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,6 @@ async function activateExtension() {`
`39`	`39`	`console.log('Python extension activated.');`
`40`	`40`	`return extension;`
`41`	`41`	`}`
`42`		`-`
`43`	`42`	`async function activateEnvsExtension() {`
`44`	`43`	`const extension = extensions.getExtension('ms-python.vscode-python-envs');`
`45`	`44`	`if (extension) {`