Edit/delete comments within the editor #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebornix
reviewed
Oct 22, 2018
src/github/pullRequestManager.ts
Outdated
| async editComment(pullRequest: IPullRequestModel, commentId: string, text: string): Promise<Comment> { | ||
| const { octokit, remote } = await (pullRequest as PullRequestModel).githubRepository.ensure(); | ||
|
|
||
| const ret = await octokit.pullRequests.editComment({ |
There was a problem hiding this comment.
We can try/catch like other methods
queerviolet
reviewed
Oct 23, 2018
src/github/credentials.ts
Outdated
| private _configuration: VSCodeConfiguration; | ||
| private _authenticationStatusBarItems: Map<string, vscode.StatusBarItem>; | ||
|
|
||
| constructor(configuration: any, | ||
| private readonly _telemetry: ITelemetry) { | ||
| this._configuration = configuration; | ||
| this._octokits = new Map<string, Octokit>(); | ||
| this._logins = new Map<string, string>(); |
There was a problem hiding this comment.
Octokit actually exposes currentUser, it's just not shown in our typings.
There was a problem hiding this comment.
hmm, I'm not seeing it on the object. Do you know when it gets set/is it at the top level as octokit.currentUser?
There was a problem hiding this comment.
Oh, lol. My bad, I put it on there in #554 😅
I guess I'd still suggest doing that, mostly bc it really seems like it should be there and we can probably pull it upstream.
RMacfarlane
force-pushed
the
rmacfarlane/edit
branch
from
bb4b41f
to
78ca42e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use the new APIs to allow editing and deleting comments. I'm restricting edit/delete to only non-outdated comments that match the logged in user, but we could relax that if needed.
I'll send a separate PR for adding edit/delete actions to comments on the description page