Skip to content

Copy GitHub __ Link actions from file/share menu copy links with file paths and line ranges #4598

@joyceerhl

Description

@joyceerhl
  1. Open a GitHub repo with the stable version of GHPRI installed
  2. Open the File > Share menu
  3. Copy GitHub Permalink, Copy GitHub HEAD Link, or Copy GitHub Permalink as Markdown
  4. 🐛 the active file path and line are included

We special-cased the file menu's behavior for copying vscode.dev links in the builtin GitHub extension and the Remote Repositories extensions to not copy the file path or line, so GHPRI's contributions to file/share are inconsistent (this is not a regression from the changes just checked into main). However @rzhao271 and @amunger had feedback that the file/share behavior was not what they expected, I think they expected it to relate to the active editor, in which case we would keep GHPRI's current behavior and change the vscode.dev link behavior.

Whatever we do here we should be consistent across all the copy link commands so I'm opening this issue to discuss the desired behavior.

Metadata

Metadata

Assignees

Labels

bugIssue identified by VS Code Team member as probable bug

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions