Skip to content

Commit d35ae53

Browse files
committed
Clean up
1 parent a5da5f7 commit d35ae53

File tree

3 files changed

+25
-26
lines changed

3 files changed

+25
-26
lines changed

src/commands.ts

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1607,7 +1607,7 @@ ${contents}
16071607

16081608
// Create QuickPick to show all PRs
16091609
const quickPick = vscode.window.createQuickPick<vscode.QuickPickItem & { pr?: PullRequestModel }>();
1610-
quickPick.placeholder = vscode.l10n.t('Select a pull request or enter a pull request number/URL');
1610+
quickPick.placeholder = vscode.l10n.t('Enter a pull request number/URL or select from the list');
16111611
quickPick.matchOnDescription = true;
16121612
quickPick.matchOnDetail = true;
16131613
quickPick.show();
@@ -1625,9 +1625,8 @@ ${contents}
16251625
// Sort PRs by number in descending order (most recent first)
16261626
const sortedPRs = prs.sort((a, b) => b.number - a.number);
16271627
const prItems: (vscode.QuickPickItem & { prNumber: number })[] = sortedPRs.map(pr => ({
1628-
label: `#${pr.number}`,
1629-
description: pr.title,
1630-
detail: `by @${pr.author.login}`,
1628+
label: `#${pr.number} ${pr.title}`,
1629+
description: `by @${pr.author.login}`,
16311630
prNumber: pr.number
16321631
}));
16331632

@@ -1653,7 +1652,7 @@ ${contents}
16531652
if (!selected) {
16541653
return;
16551654
}
1656-
1655+
quickPick.busy = true;
16571656
let prModel: PullRequestModel | undefined;
16581657

16591658
// Check if user selected from the list or typed a custom value

src/github/queries.gql

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -763,25 +763,4 @@ mutation ReplaceActorsForAssignable($input: ReplaceActorsForAssignableInput!) {
763763
}
764764
}
765765
}
766-
}
767-
768-
fragment PullRequestNumberFragment on PullRequest {
769-
number
770-
title
771-
author {
772-
login
773-
}
774-
}
775-
776-
query PullRequestNumbers($owner: String!, $name: String!, $first: Int!) {
777-
repository(owner: $owner, name: $name) {
778-
pullRequests(first: $first, states: OPEN, orderBy: { field: CREATED_AT, direction: DESC }) {
779-
nodes {
780-
...PullRequestNumberFragment
781-
}
782-
}
783-
}
784-
rateLimit {
785-
...RateLimit
786-
}
787766
}

src/github/queriesShared.gql

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -686,6 +686,27 @@ query PullRequestTemplates($owner: String!, $name: String!) {
686686
}
687687
}
688688

689+
fragment PullRequestNumberFragment on PullRequest {
690+
number
691+
title
692+
author {
693+
login
694+
}
695+
}
696+
697+
query PullRequestNumbers($owner: String!, $name: String!, $first: Int!) {
698+
repository(owner: $owner, name: $name) {
699+
pullRequests(first: $first, states: OPEN, orderBy: { field: CREATED_AT, direction: DESC }) {
700+
nodes {
701+
...PullRequestNumberFragment
702+
}
703+
}
704+
}
705+
rateLimit {
706+
...RateLimit
707+
}
708+
}
709+
689710
mutation AddComment($input: AddPullRequestReviewCommentInput!) {
690711
addPullRequestReviewComment(input: $input) {
691712
comment {

0 commit comments

Comments
 (0)