Skip to content

Commit 666fb14

Browse files
authored
Fix closed issue color in notifications view (#8305)
Fixes #7300
1 parent 45c5392 commit 666fb14

File tree

3 files changed

+12
-2
lines changed

3 files changed

+12
-2
lines changed

package.json

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3696,6 +3696,16 @@
36963696
},
36973697
"description": "The color used for indicating that an issue is closed."
36983698
},
3699+
{
3700+
"id": "github.issues.closed",
3701+
"defaults": {
3702+
"dark": "pullRequests.merged",
3703+
"light": "pullRequests.merged",
3704+
"highContrast": "editor.foreground",
3705+
"highContrastLight": "editor.foreground"
3706+
},
3707+
"description": "The color used for indicating that an issue is closed. Duplicates issues.closed because there's another extension that uses this identifier."
3708+
},
36993709
{
37003710
"id": "pullRequests.merged",
37013711
"defaults": {

src/issues/issuesView.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ export class IssuesTreeData
104104
treeItem.iconPath = (await DataUri.avatarCirclesAsImageDataUris(this.context, [avatarUser], 16, 16))[0] ??
105105
(element.isOpen
106106
? new vscode.ThemeIcon('issues', new vscode.ThemeColor('issues.open'))
107-
: new vscode.ThemeIcon('issue-closed', new vscode.ThemeColor('issues.closed')));
107+
: new vscode.ThemeIcon('issue-closed', new vscode.ThemeColor('github.issues.closed')));
108108
} else {
109109
// Use GitHub codicon when assignee setting is selected but no assignees exist
110110
treeItem.iconPath = new vscode.ThemeIcon('github');

src/notifications/notificationsManager.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ export class NotificationsManager extends Disposable implements vscode.TreeDataP
121121
if (notification.subject.type === NotificationSubjectType.Issue && model instanceof IssueModel) {
122122
item.iconPath = element.model.isOpen
123123
? new vscode.ThemeIcon('issues', new vscode.ThemeColor('issues.open'))
124-
: new vscode.ThemeIcon('issue-closed', new vscode.ThemeColor('issues.closed'));
124+
: new vscode.ThemeIcon('issue-closed', new vscode.ThemeColor('github.issues.closed'));
125125
}
126126
if (notification.subject.type === NotificationSubjectType.PullRequest && model instanceof PullRequestModel) {
127127
item.iconPath = model.isOpen

0 commit comments

Comments
 (0)