Skip to content

Add calls to validatePosition for some requests #637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Add calls to validatePosition for some requests #637

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
949a8ec
Add calls to validatePosition for some requests
davidanthoff Jun 11, 2020
22a126b
Fix typos
davidanthoff Jun 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions client/src/common/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1502,7 +1502,8 @@ class CompletionItemFeature extends TextDocumentFeature<CompletionOptions, Compl
const client = this._client;
const middleware = this._client.clientOptions.middleware!;
const provideCompletionItems: ProvideCompletionItemsSignature = (document, position, context, token) => {
return client.sendRequest(CompletionRequest.type, client.code2ProtocolConverter.asCompletionParams(document, position, context), token).then(
const validatedPosition = document.validatePosition(position);
return client.sendRequest(CompletionRequest.type, client.code2ProtocolConverter.asCompletionParams(document, validatedPosition, context), token).then(
client.protocol2CodeConverter.asCompletionResult,
(error) => {
return client.handleFailedRequest(CompletionRequest.type, error, null);
Expand Down Expand Up @@ -1664,7 +1665,8 @@ class DefinitionFeature extends TextDocumentFeature<boolean | DefinitionOptions,
provideDefinition: (document, position, token) => {
const client = this._client;
const provideDefinition: ProvideDefinitionSignature = (document, position, token) => {
return client.sendRequest(DefinitionRequest.type, client.code2ProtocolConverter.asTextDocumentPositionParams(document, position), token).then(
const validatedPosition = document.validatePosition(position);
return client.sendRequest(DefinitionRequest.type, client.code2ProtocolConverter.asTextDocumentPositionParams(document, validatedPosition), token).then(
client.protocol2CodeConverter.asDefinitionResult,
(error) => {
return client.handleFailedRequest(DefinitionRequest.type, error, null);
Expand Down
3 changes: 2 additions & 1 deletion client/src/common/typeDefinition.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,8 @@ export class TypeDefinitionFeature extends TextDocumentFeature<boolean | TypeDef
provideTypeDefinition: (document, position, token) => {
const client = this._client;
const provideTypeDefinition: ProvideTypeDefinitionSignature = (document, position, token) => {
return client.sendRequest(TypeDefinitionRequest.type, client.code2ProtocolConverter.asTextDocumentPositionParams(document, position), token).then(
const validatedPosition = document.validatePosition(position);
return client.sendRequest(TypeDefinitionRequest.type, client.code2ProtocolConverter.asTextDocumentPositionParams(document, validatedPosition), token).then(
client.protocol2CodeConverter.asDefinitionResult,
(error) => {
return client.handleFailedRequest(TypeDefinitionRequest.type, error, null);
Expand Down