Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify that the workspace.applyEdit feature is enabled in the client #264

Merged
merged 1 commit into from
Oct 16, 2017

Conversation

rcjsuen
Copy link
Contributor

@rcjsuen rcjsuen commented Oct 15, 2017

Not sure if this is the right way of going about it but it does address#263.

As the vscode-languageclient package supports the handling of
workspace/applyEdit requests, it should make it known in the initial
handshake that is sent to the server.

Signed-off-by: Remy Suen <remy.suen@gmail.com>
@msftclas
Copy link

@rcjsuen,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@dbaeumer
Copy link
Member

Thanks. This got lost when introducing the feature structure for the client.

@dbaeumer dbaeumer merged commit 42a04f6 into microsoft:master Oct 16, 2017
@rcjsuen rcjsuen deleted the applyEdit branch January 10, 2018 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants