Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging for kernel context keys #15916

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Yoyokrazy
Copy link
Contributor

@Yoyokrazy Yoyokrazy commented Aug 2, 2024

Re: #200896

Added debug logging to diagnose context key issues causing disappearing global toolbar buttons (restart).

@Yoyokrazy Yoyokrazy self-assigned this Aug 2, 2024
@vs-code-engineering vs-code-engineering bot added this to the August 2024 milestone Aug 2, 2024
@DonJayamanne
Copy link
Contributor

@Yoyokrazy If you only need this for debugging purposes, then you can

  • Make this change, create a PR as you have done
  • Take the VSIX from the build output
  • Share the VSIX with users, ask them to test by installing this VSIX manually
  • Capture the logs

Else we end up with a lot of logs when users click around/typing etc (as such actions causes these context keys to change and that would produce an excessive amount of logging for all users, which wouldnt be ideal)

Copy link
Contributor

@DonJayamanne DonJayamanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only requesting chanages so as to ensure we do not merge this PR,
Feel free to use the VSIX and share that with the users for capturing logs.

@Yoyokrazy Yoyokrazy modified the milestones: August 2024, September 2024 Aug 28, 2024
@Yoyokrazy Yoyokrazy modified the milestones: September 2024, Backlog Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants