Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kernel selection dialog: Show current kernel as well #8044

Closed
aeschli opened this issue Oct 26, 2021 · 4 comments
Closed

Kernel selection dialog: Show current kernel as well #8044

aeschli opened this issue Oct 26, 2021 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug notebook-kernel Kernels issues (start/restart/switch/execution, install ipykernel)

Comments

@aeschli
Copy link

aeschli commented Oct 26, 2021

Testing #7373

Just a UI suggestion. Feel free to close if this was already discussed.

Following #8032, I installed some environments and opened a Jupyter notebook.
Clicking on the environments brings the 'Kernel change dialog'. It shows all kernels except the currently selected one.

I found that filtering teh current one is a but strange. Comparing this to other selection dialogs, e.g. the editor language mode, or the theme selection dialog, git branch dialog, we always show the current one as well.

The current one can be marked specially or selected initially. It allows the user to better compare the options, keeps the list stable in appearance and allows the user to select the current one, after considering other options.

@DonJayamanne
Copy link
Contributor

Thanks, the current selected one is displayed if you had previously selected one. It'll be suffixed with the text selected, it's not on the top thought.

Closing as there's been a lot of discussion around where and how this needs to be displayed.

Thanks for the suggestion.

@aeschli
Copy link
Author

aeschli commented Oct 26, 2021

image

It looks like the selected one is always filtered.

@aeschli
Copy link
Author

aeschli commented Oct 26, 2021

Maybe move the issue to Core if that's where the list is rendered.

@DonJayamanne
Copy link
Contributor

DonJayamanne commented Oct 26, 2021

looks like the selected one is always filtered.

Did you exclude this (env1) from the list (ie was it filtered out from the list of kernels using the new UI?)

@DonJayamanne DonJayamanne reopened this Oct 26, 2021
@DonJayamanne DonJayamanne reopened this Oct 26, 2021
@greazer greazer added bug Issue identified by VS Code Team member as probable bug notebook-kernel Kernels issues (start/restart/switch/execution, install ipykernel) and removed needs-triage labels Oct 28, 2021
@greazer greazer closed this as completed Oct 28, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug notebook-kernel Kernels issues (start/restart/switch/execution, install ipykernel)
Projects
None yet
Development

No branches or pull requests

3 participants