Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect paths displayed for non-python kernels in kernel picker #7931

Closed
DonJayamanne opened this issue Oct 14, 2021 · 1 comment
Closed

Incorrect paths displayed for non-python kernels in kernel picker #7931

DonJayamanne opened this issue Oct 14, 2021 · 1 comment
Assignees
@DonJayamanne
Labels
bug Issue identified by VS Code Team member as probable bug notebook-kernel Kernels issues (start/restart/switch/execution, install ipykernel) verified Verification succeeded
Milestone
October 2021

Comments

@DonJayamanne
Copy link
Contributor

DonJayamanne commented Oct 14, 2021 •
edited
Loading

If we have a non-python kernel, we display the path of the interpreter that owns the kernel instead of the path to the kernel exec.

Found while working on #7373

Current behavior
image

Expected behaviour
image
@DonJayamanne DonJayamanne added the bug Issue identified by VS Code Team member as probable bug label Oct 14, 2021
@DonJayamanne DonJayamanne self-assigned this Oct 14, 2021
@DonJayamanne DonJayamanne added the notebook-kernel Kernels issues (start/restart/switch/execution, install ipykernel) label Oct 14, 2021
@DonJayamanne DonJayamanne added this to the October 2021 milestone Oct 14, 2021
@DonJayamanne DonJayamanne changed the title Path displayed for non-python kernel is wrong Incorrect paths displayed for non-python kernels in kernel picker Oct 14, 2021
@DonJayamanne DonJayamanne mentioned this issue Oct 14, 2021
Merged
@DonJayamanne
Copy link
Contributor Author

Verification steps:

  • Install non-python kernel spec (such as sage or other that's installed as part of a conda package)
  • Ensure the path to the process used to launch the kernel is dispalyed (instead of the python interpreter)

@tanhakabir tanhakabir added the verified Verification succeeded label Oct 28, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DonJayamanne DonJayamanne

Labels
bug Issue identified by VS Code Team member as probable bug notebook-kernel Kernels issues (start/restart/switch/execution, install ipykernel) verified Verification succeeded
Projects
None yet
Milestone
October 2021
Development

No branches or pull requests
2 participants
@DonJayamanne @tanhakabir