Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactive window prompts to save before closing #12638

Closed
joyceerhl opened this issue Jan 24, 2023 · 3 comments
Closed

Interactive window prompts to save before closing #12638

joyceerhl opened this issue Jan 24, 2023 · 3 comments
Assignees

Comments

@joyceerhl
Copy link
Contributor

Testing #12613

Have an interactive window, run cells in it, then try to close. I get prompted to save unsaved changes (which is surprising in and of itself), but clicking save just dismisses the window instead of what I'd expect (open system file dialog with option to save the file).

image

@amunger
Copy link
Contributor

amunger commented Jan 24, 2023

@joyceerhl - does this repro for you every time? I can't get it to happen. Do you see a dirty indicator on the tab?

@joyceerhl
Copy link
Contributor Author

Yes I do see a dirty indicator. Honestly not entirely sure how I got into this state. Maybe related to the IW restoring following a window reload?

@joyceerhl
Copy link
Contributor Author

Oh wait, I just reproed it.
image

  1. Jupyter: Create Interactive Window
  2. Reload with restore enabled
  3. 🐛 a second editor appears, and that one is marked dirty and will trigger the save dialog when closed

@amunger amunger closed this as completed Jan 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants