-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add basic network view, support experimental networking for node #2053
Conversation
This adds a basic network tree view that shows requests and responses in the debugee. It has a default "go to" action which opens a cURL representation of the request, and context menu actions to open the response body either in a text editor or the hex editor. It also has actions to copy the URL and replay the request. ![](https://memes.peet.io/img/24-08-aa5f7f35-332f-4a60-9fbb-32ac79018b60.png) I initially was hoping to turn this on by default for Node.js since their networking support in 22.6.0 inspired this change, but their functionality right now is very limited (we basically get the URL and nothing else.) Therefore I added an option to turn it on, but it's not on by default there. I think I might end up toggling this off for the next stable release for now until we can polish it some more, but it's ship it in nightly to get some feedback!
build failure is a known flake that's on my todo |
How do I enable this feature? I installed latest nightly version but don't see "network" tab in there. |
It's automatically available if the debug target supports networking |
I am trying to debug an API call from a local VScode extension through debugger(which technically opens a new VScode window), is that supported? |
VS Code extensions run in the extension host which is not on Node >=22.6 where networking support is available. |
Hmm I see, is that something I can update for my extension and upgrade node to >=22.6 or extension host node version needs to be upgraded by you guys? |
The extension host's node is bundled with VS Code and isn't upgradable by users. And as I mentioned in the PR the network support Node added in 22.6 is very preliminary and not incredibly useful at the moment, so it'll be a minute. This works for browsers however. |
Hi @connor4312 - I've tried that in the nightly build (I know it's not useful atm but wanted to check it out) I have Any ideas on what it could be? |
You'll want to also enable the VS Code setting |
This adds a basic network tree view that shows requests and responses
in the debugee. It has a default "go to" action which opens a cURL
representation of the request, and context menu actions to open the
response body either in a text editor or the hex editor. It also has
actions to copy the URL and replay the request.
I initially was hoping to turn this on by default for Node.js since
their networking support in 22.6.0 inspired this change, but their
functionality right now is very limited (we basically get the URL and
nothing else.) Therefore I added an option to turn it on, but it's not
on by default there.
I think I might end up toggling this off for the next stable release
for now until we can polish it some more, but it's ship it in nightly
to get some feedback!
Closes #2051