Fix formatting of number 0 in remote object when description is not set #1968
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue reported here: #1967
Some Javascript Debuggee CDP implementations (Hermes) return the a RemoteObject of
type=number
,value=0
and thedescription
andunserializableValue
fields unset. This causes RemoteObjects withtype=number
andvalue=0
to be rendered as NaN due to the logic of formatting numbers here:vscode-js-debug/src/adapter/objectPreview/index.ts
Lines 477 to 484 in 35c4aea