SourceMaps don't bind on latest next.js version server side (Docker)

[jasonwilliams]

Describe the bug
Next.js now uses eval-source-map from version 9 onwards.
It looks like eval-source-map generates webpack-internal:///./ references.

I added the settings below but it makes no difference:

      "sourceMapPathOverrides": {
        "webpack-internal:///./": "${workspaceFolder}/"
      }

I wonder if

vscode-js-debug/src/targets/browser/browserPathResolver.ts

Lines 111 to 113 in e2191de

	if (parsed.protocol === 'webpack-internal:') {
	return undefined;
	}

has anything to do with it?

Should webpack-internal:///./ be added to this list?

vscode-js-debug/src/configuration.ts

Lines 931 to 939 in 4d7737f

	export function defaultSourceMapPathOverrides(webRoot: string): { [key: string]: string } {
	return {
	'webpack:///./~/*': `${webRoot}/node_modules/*`,
	'webpack:////*': '/*',
	'webpack://?:*/*': `${webRoot}/*`,
	'webpack:///([a-z]):/(.+)': '$1:/$2',
	'meteor://💻app/*': `${webRoot}/*`,
	};
	}

To Reproduce
Steps to reproduce the behavior:

1. Clone https://github.com/jasonwilliams/nextjs9-typescript-server-vscode-example
2. yarn install
3. docker-composer up
4. Launch -> launch server (Docker)
5. set a breakpoint in pages/index.tsx

Log File

VS Code Version: 1.51

[connor4312]

Thanks for the great issue as usual, this is actually an issue with resolveSourceMapLocations being narrowed. Previously for some reason I only removed the narrowing for launch rather than attach types. But I don't recall why I did this and I think it's wrong. Fixed in the next nightly. You don't need to specify a sourceMapPathOverride

[jasonwilliams]

This isn't fixed for me

My nightly version is 2020.11.1117

[connor4312]

To confirm, did you remove the sourceMapPathOverrides in the launch server (Docker) configuration?

[jasonwilliams]

@connor4312 I can confirm its the same whether I have sourceMapPathOverrides set or not. I removed sourceMapPathOverrides and it still doesn't bind and the output I get in diagnostics is the same.
On the test repo I tried launch and it does work for that. Did your change make it to my nightly version? Or maybe the problem is something else.

[jasonwilliams]

@connor4312 This is still broken for me on v2020.11.2317 can we re-open this issue? I can also confirm there is no sourceMapPathOverrides in my configuration

[jasonwilliams]

I've had a go at debugging this, and dusted off my local copy of js-debug. It looks like urlToAbsolutePath fails with webpack-internal:// urls.

You can see here on line 836 it returns an empty string:

However for other files it works fine:

I could be off here, but there's definitely something odd. My head hurts now