Issue #835: Making sure vscode cleans up the running test

[calvin1864]

If a build fails and the user selects to Abort the running tests, the cleanup method is never called and the isRunning boolean is stranded as true.

This forces cleanup to occur if the user abandons their test run to fix build issues

[jdneo]

Hi @calvin1864,

Thank you for providing this PR. This remind me that I need to do more refactoring work about the Scheduler.

The background is that previously, the Test Runner will launch a Java process by itself to run the tests. While recently I'm doing the refactoring work to migrate the launch task to Java Debugger. What the Test Runner does is just pass a launch configuration to the Java Debugger.

In #850, I removed the setting java.test.forceBuildBeforeLaunchTest and its related handling logic, because the users can use the same setting in debugger instead(java.debug.settings.forceBuildBeforeLaunch).

So the potential bug we mentioned here should disappear because the codes are actually removed.

But anyway, I still want to thank you for finding this out! I'll keep an eye on this issue to see if there are other cases to cause the bug.

BTW, if you are interested, Please feel free to have a try with the latest build. You can pull the latest bits from the master branch.

[calvin1864]

Thanks. I saw your PR and update.

I'll close this without merging and test your change (at least for the issue I'm aware of). I'm looking forward to it!