feat: Support running tests from Java Project explorer #1125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eskibear
reviewed
Jan 18, 2021
| if (packageFragment != null && packageFragment instanceof IPackageFragment) { | ||
| final IJavaElement[] packages = ((IPackageFragmentRoot) packageFragment.getParent()).getChildren(); | ||
| for (final IJavaElement p : packages) { | ||
| if (!(p instanceof IPackageFragment)) { |
There was a problem hiding this comment.
looks better in style?
if (p instanceof IPackageFragment)
if (p.getElementName().startsWith(packageFragment.getElementName()))
result.add((IPackageFragment) p);
There was a problem hiding this comment.
Got the point, or maybe merge the if blocks into one?
Eskibear
previously approved these changes
Jan 18, 2021
| /** | ||
| * Get all sub-packages whose name starts with the given package. | ||
| */ | ||
| public static IPackageFragment[] getAllSubPackages(IJavaElement packageFragment) throws CoreException { |
There was a problem hiding this comment.
this method actually returns the package itself and its children, so a better name should be getPackageAndSubpackages.
There was a problem hiding this comment.
There is duplicated utility in jdt.core.manipulation jar.
See org.eclipse.jdt.internal.corext.refactoring.util.JavaElementUtil.getPackageAndSubpackages(), suggest to reuse it.
There was a problem hiding this comment.
Yes that will be much better.
testforstephen
approved these changes
Jan 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support run tests from the Java Project explorer
Demo
demo.mp4
Note
Since we need to run all the children nodes if the explorer is in Hierarchical mode, so I made some workaround in the implementation. Basically it's to patch the arguments resolved by the configuration delegator.