Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Only show migrate command when workspace has deprecated files #1084

Merged
merged 3 commits into from
Oct 22, 2020

Conversation

jdneo
Copy link
Member

@jdneo jdneo commented Oct 20, 2020

No description provided.

@jdneo jdneo added the eng Debts for engineering label Oct 20, 2020
@jdneo jdneo added this to the 0.26.0 milestone Oct 20, 2020
src/extension.ts Outdated
const deprecatedConfigs: Uri[] = await workspace.findFiles('**/.vscode/launch.test.json', null, 1 /*maxResult*/);
if (deprecatedConfigs.length > 0) {
commands.executeCommand('setContext', 'java:hasDeprecatedTestConfig', true);
sendInfo('', { hasDeprecatedTestConfig: 1 });
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hasDeprecatedTestConfig: 1 would cause telemetry data goes into measure instead of properties. Consider to use true or "1"?

@jdneo jdneo merged commit 3b18a2c into master Oct 22, 2020
@jdneo jdneo deleted the cs/migrate branch October 22, 2020 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
eng Debts for engineering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants