-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref: adopt vscode's styling in beginner tips page #831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Eskibear
commented
Nov 29, 2021
- use vscode-webview-ui-toolkit
Eskibear
requested review from
CsCherrYY,
jdneo and
testforstephen
as code owners
November 29, 2021 09:03
This comment has been minimized.
This comment has been minimized.
Eskibear
commented
Nov 30, 2021
Signed-off-by: Yan Zhang <yanzh@microsoft.com>
Signed-off-by: Yan Zhang <yanzh@microsoft.com>
Signed-off-by: Yan Zhang <yanzh@microsoft.com>
Signed-off-by: Yan Zhang <yanzh@microsoft.com>
@jdneo @CsCherrYY please help to take a look or play with the PR build, verify if it's working well. |
CsCherrYY
reviewed
Dec 1, 2021
CsCherrYY
reviewed
Dec 1, 2021
Signed-off-by: Yan Zhang <yanzh@microsoft.com>
just my own opinion, I just zoom in once than the default zoom in my PC (2k resolution), the font size of current version is a little small and a little hard to read many words in a page. The marketplace version has a gray background so it may look better. Can we consider increasing the font size? |
now:
|
Signed-off-by: Yan Zhang <yanzh@microsoft.com>
CsCherrYY
approved these changes
Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.