Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: adopt vscode's styling in beginner tips page #831

Merged
merged 6 commits into from
Dec 1, 2021
Merged

Conversation

Eskibear
Copy link
Member

  • use vscode-webview-ui-toolkit

@Eskibear

This comment has been minimized.

@Eskibear Eskibear added this to the 0.19.0 milestone Nov 29, 2021
Signed-off-by: Yan Zhang <yanzh@microsoft.com>
Signed-off-by: Yan Zhang <yanzh@microsoft.com>
Signed-off-by: Yan Zhang <yanzh@microsoft.com>
Signed-off-by: Yan Zhang <yanzh@microsoft.com>
@Eskibear
Copy link
Member Author

Eskibear commented Dec 1, 2021

demo:

image

@Eskibear
Copy link
Member Author

Eskibear commented Dec 1, 2021

@jdneo @CsCherrYY please help to take a look or play with the PR build, verify if it's working well.

Signed-off-by: Yan Zhang <yanzh@microsoft.com>
@CsCherrYY
Copy link
Contributor

just my own opinion, I just zoom in once than the default zoom in my PC (2k resolution), the font size of current version is a little small and a little hard to read many words in a page. The marketplace version has a gray background so it may look better. Can we consider increasing the font size?

@Eskibear
Copy link
Member Author

Eskibear commented Dec 1, 2021

now:

code {
    font-family: var(--vscode-editor-font-family);
}

Signed-off-by: Yan Zhang <yanzh@microsoft.com>
@Eskibear Eskibear merged commit 4543539 into main Dec 1, 2021
@Eskibear Eskibear deleted the ref-gs-page branch December 1, 2021 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants