More detailed language pack extension description #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eskibear
reviewed
Jun 22, 2021
package.json
Outdated
| @@ -55,6 +55,7 @@ | |||
| "onWebviewPanel:java.welcome", | |||
| "onCommand:java.classpathConfiguration", | |||
| "onWebviewPanel:java.classpathConfiguration", | |||
| "onWebviewPanel:java.markdownPreview", | |||
There was a problem hiding this comment.
what's this line for? @jdneo please take a look
There was a problem hiding this comment.
i don't think i edited this line but somehow it's showing up here, i can remove it if helps
There was a problem hiding this comment.
This line has been removed in a recent commit. Feel safe to remove it
package.json
Outdated
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "name": "vscode-java-pack", | |||
| "displayName": "Java Extension Pack", | |||
| "description": "Popular extensions for Java development and more.", | |||
| "description": "Popular extensions for Java development that provides Java intellisense, debugging, testing, Maven support, project management and more", | |||
There was a problem hiding this comment.
intellisense -> IntelliSense. It's a general term. See https://code.visualstudio.com/docs/editor/intellisense
Maven support -> Maven/Gradle support
jdneo
approved these changes
Jun 22, 2021
|
anyone can help to merge this PR? I don't have write access : ( thanks~ |
|
Thank you @nickzhums |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By looking at the description of other language extensions, our java extension pack description is quite simple, so adding a few more details to provide more clarity for developers