From 90945ca261c62729d9abcabe0134b1492cf2f3ac Mon Sep 17 00:00:00 2001 From: sezna Date: Mon, 26 Feb 2024 14:34:02 -0800 Subject: [PATCH] Use clean user agent string instead of appVersion when userAgentData is unavailable --- src/browser/telemetryReporter.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/browser/telemetryReporter.ts b/src/browser/telemetryReporter.ts index a850cbf..b20cc5d 100644 --- a/src/browser/telemetryReporter.ts +++ b/src/browser/telemetryReporter.ts @@ -14,7 +14,9 @@ function getBrowserRelease(navigator: Navigator): string { const browser = navigator.userAgentData.brands[navigator.userAgentData.brands.length - 1]; return `${navigator.userAgentData.platform} - ${browser?.brand} v${browser?.version}}`; } else { - return navigator.appVersion; + // clean the user agent using the logic from here: + // https://github.com/microsoft/vscode/blob/main/src/vs/workbench/services/telemetry/browser/workbenchCommonProperties.ts#L14C1-L21C2 + return navigator.userAgent.replace(/(\d+\.\d+)(\.\d+)+/g, "$1"); } }