Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python-images-updates #6080

Merged
merged 10 commits into from
Feb 28, 2023
Merged

Python-images-updates #6080

merged 10 commits into from
Feb 28, 2023

Conversation

cwebster-99
Copy link
Member

@cwebster-99 cwebster-99 commented Feb 24, 2023

Updating Python related images to reflect up to date UI

@cwebster-99 cwebster-99 removed the request for review from luabud February 24, 2023 22:16
@luabud
Copy link
Member

luabud commented Feb 24, 2023

This looks great to me, thank you!

The one thing I'm wondering is whether we should hide the icons in the activity bar that don't come by default (e.g. GitHub, live share, etc.), just so users don't get confused in case they think the icons should show up as they follow along the documentation. @gregvanl do you have thoughts/guidance on this?

@gregvanl
Copy link

gregvanl commented Feb 25, 2023

Yes, it is better to have a clean Stable build without extra customizations for taking screenshots.
With the new Profiles feature, you can create an Empty Profile (File > Preferences > Profiles > Create Profile then select Create an Empty Profile) to have a clean editor.

I'm confused by a couple of the images not rendering in the PR. Any idea what's up with new-file-icon.png and debug-panel-initial-view.png? If you View File, the file contents looks like Git LFS goop?

You might try reverting the change and updating them again. All the other images render correctly on GitHub and are correctly stored in Git LFS

@cwebster-99
Copy link
Member Author

Good feedback! I just updated the images to clean up the activity bar and then reuploaded the images that did not render.

@gregvanl gregvanl merged commit 8859963 into main Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants