-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python-images-updates #6080
Python-images-updates #6080
Conversation
This looks great to me, thank you! The one thing I'm wondering is whether we should hide the icons in the activity bar that don't come by default (e.g. GitHub, live share, etc.), just so users don't get confused in case they think the icons should show up as they follow along the documentation. @gregvanl do you have thoughts/guidance on this? |
Yes, it is better to have a clean Stable build without extra customizations for taking screenshots. I'm confused by a couple of the images not rendering in the PR. Any idea what's up with new-file-icon.png and debug-panel-initial-view.png? If you View File, the file contents looks like Git LFS goop? You might try reverting the change and updating them again. All the other images render correctly on GitHub and are correctly stored in Git LFS |
Good feedback! I just updated the images to clean up the activity bar and then reuploaded the images that did not render. |
Updating Python related images to reflect up to date UI