-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AI doc feedback #6064
AI doc feedback #6064
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for updating the docs. I left some minor comments :)
For intelli-sense / inline suggestion interaction I would not mention anything right now. We can add it to the FAQ if we add such a section in the future.
Thanks for the review @isidorn! Let me know what you think with the latest changes. |
@@ -23,9 +23,9 @@ You'll use the [GitHub Copilot extension](https://marketplace.visualstudio.com/i | |||
|
|||
To use GitHub Copilot, you need an active GitHub Copilot subscription. In the [content below](#activate-your-free-trial), you'll learn how VS Code will help you activate your free 60-day trial directly from VS Code. | |||
|
|||
You can also activate your trial starting from the [GitHub Copilot website](https://copilot.github.com/): | |||
You can also activate your trial starting from the [GitHub Copilot website](https://copilot.github.com/), selecting "Start my free trial" (highlighted in the image below): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we consider taking that image out, given that Start Trial is the primary CTA on that page? Would make for a smoother content flow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also just noticed that I only see a "Copilot for Business" CTA on that page. One solution would be to directly link to https://github.com/github-copilot/signup .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good feedback on the relevance of the page overall. With this, I think it makes sense to just link to the signup link you shared. Updated the link and removed the image.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, looks good to me. Thanks for doing these updates!
Hi @bamurtaugh For the Ctrl+-> formatting, you can use |
Thanks so much @gregvanl, looks great! |
@digitarald looks like since you requested changes, you'll need to approve that your changes were met 😄 |
@gregvanl this is ready for your review and merge whenever you get a chance! |
Updates to address @isidorn's feedback:
Alternative and partial solutions
section - describes using the inline suggestion hover to see multiple suggestions and accept full or partial solutionsthe GitHub Copilot command palette for choosing suggestions.
I also referred to it as theGitHub Copilot command palette
, but let me know if we should use other wording we might've already introduced in docs/release notesStart my free trial
button with a red box, based on @isidorn's feedback it originally seemed clickable or unhelpful@gregvanl My keyboard shortcuts formatting in line 99 probably aren't optimal, as a heads up 😄.