Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AI doc feedback #6064

Merged
merged 12 commits into from
Feb 27, 2023
Merged

AI doc feedback #6064

merged 12 commits into from
Feb 27, 2023

Conversation

bamurtaugh
Copy link
Member

Updates to address @isidorn's feedback:

  • Add Alternative and partial solutions section - describes using the inline suggestion hover to see multiple suggestions and accept full or partial solutions
    • @isidorn @hediet I notice in the GH doc, they describe this as the GitHub Copilot command palette for choosing suggestions. I also referred to it as the GitHub Copilot command palette, but let me know if we should use other wording we might've already introduced in docs/release notes
  • I updated the second image on the page (showing the top of the Copilot landing page) to highlight the Start my free trial button with a red box, based on @isidorn's feedback it originally seemed clickable or unhelpful
  • @isidorn you mentioned adding "Interaction between intelli-sense and inline suggestions." I think this is interesting but didn't add anything on it yet. Let me know if you had any specific content in mind, happy to include it!

@gregvanl My keyboard shortcuts formatting in line 99 probably aren't optimal, as a heads up 😄.

Copy link
Contributor

@isidorn isidorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for updating the docs. I left some minor comments :)
For intelli-sense / inline suggestion interaction I would not mention anything right now. We can add it to the FAQ if we add such a section in the future.

docs/editor/artificial-intelligence.md Outdated Show resolved Hide resolved
docs/editor/artificial-intelligence.md Show resolved Hide resolved
@bamurtaugh
Copy link
Member Author

Thanks for the review @isidorn! Let me know what you think with the latest changes.

@@ -23,9 +23,9 @@ You'll use the [GitHub Copilot extension](https://marketplace.visualstudio.com/i

To use GitHub Copilot, you need an active GitHub Copilot subscription. In the [content below](#activate-your-free-trial), you'll learn how VS Code will help you activate your free 60-day trial directly from VS Code.

You can also activate your trial starting from the [GitHub Copilot website](https://copilot.github.com/):
You can also activate your trial starting from the [GitHub Copilot website](https://copilot.github.com/), selecting "Start my free trial" (highlighted in the image below):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we consider taking that image out, given that Start Trial is the primary CTA on that page? Would make for a smoother content flow.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also just noticed that I only see a "Copilot for Business" CTA on that page. One solution would be to directly link to https://github.com/github-copilot/signup .

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good feedback on the relevance of the page overall. With this, I think it makes sense to just link to the signup link you shared. Updated the link and removed the image.

isidorn
isidorn previously approved these changes Feb 24, 2023
Copy link
Contributor

@isidorn isidorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good to me. Thanks for doing these updates!

@gregvanl
Copy link

gregvanl commented Feb 27, 2023

Hi @bamurtaugh For the Ctrl+-> formatting, you can use kbstyle(Ctrl+RightArrow). I made a couple of formatting edits and now that section looks like:

image

@bamurtaugh
Copy link
Member Author

Thanks so much @gregvanl, looks great!

@bamurtaugh
Copy link
Member Author

@digitarald looks like since you requested changes, you'll need to approve that your changes were met 😄

@bamurtaugh
Copy link
Member Author

@gregvanl this is ready for your review and merge whenever you get a chance!

@gregvanl gregvanl merged commit 7f7af4e into main Feb 27, 2023
@gregvanl gregvanl deleted the bamurtaugh/ai-feedback branch February 27, 2023 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants