-
Notifications
You must be signed in to change notification settings - Fork 191
SCSS modules #183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SCSS modules #183
Conversation
thank you for this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very high quality work! Just some nitpicks.
While you are on it, maybe update findDocumentLinks
of scssNavigation.ts
as well? Currently the paths are not linked so you cannot cmd+click into them.
Done. Separately while working on this, I noticed some things that I think are out of scope for this pull request: src/test/scss/scssNavigation.test.ts:53: if (stats.isFile()) {
type = FileType.File;
- } else if (stats.isDirectory) {
+ } else if (stats.isDirectory()) {
type = FileType.Directory;
- } else if (stats.isSymbolicLink) {
+ } else if (stats.isSymbolicLink()) {
type = FileType.SymbolicLink;
} Typescript threw some errors here, saying that these were probably meant to be method calls. src/services/cssNavigation.ts:14 -import { endsWith, startsWith } from '../utils/strings';
+import { startsWith } from '../utils/strings';
src/services/scssNavigation.ts:24 - public findDocumentLinks(
- document: TextDocument,
- stylesheet: nodes.Stylesheet,
- documentContext: DocumentContext
- ): DocumentLink[] {
- return super.findDocumentLinks(document, stylesheet, documentContext);
- } I don't believe this method override is needed if it is only calling |
Thanks again, I fixed them up with |
Dart Sass 1.23.0 dropped recently and with it, a new module system.
This pull request adds parsing for:
@use
@forward
module.$variables
module.functions()
@include module.includes
Related to microsoft/vscode#81943.