Fail to create resource using view/title button

[alexweininger]

Currently reproduces on 1.71.0-insider, caused by microsoft/vscode#157803

Repro steps:

1. Click "Create Resource" from the view/title.
2. Select any option (Function App for example)

Screen.Recording.2022-08-17.at.4.16.32.PM.mov

[alexweininger]

Release of the feature that causes this bug is being delayed until September microsoft/vscode#42903 (comment)

I don't think this feature will break any other commands, it only impacts commands that are invoked via a view/title button. Currently the only commands we have for view/title are Create Resource, and Refresh.

[alexweininger]

So seems like the new way they implemented it no longer breaks the commands.

[nturinski]

Yep, confirms that it seems fine for me too, but should probably investigate what's really getting passed back.

[alexweininger]

investigation update...

The callback is passed two arguments, 1. the focused tree item, and then 2. an array of the selected tree items.

The focused tree item argument does replace our subscription argument, however, since each node has access to the subscription, it works all the same. We will have to plan for this for v2.

This does change the UX slightly. For example, if the user has two subscriptions shown previously we'd prompt them to pick a subscription. However, if the user has a node focused, the subscription that node is under will be auto picked.

[nturinski]

Thanks for investigating this. I guess we shouldn't close it necessarily since we should keep it in mind, but then it shouldn't cause any issues 👍?

[alexweininger]

Fixed by a PR a while ago...