-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[copypp] New port #35309 #35310
[copypp] New port #35309 #35310
Conversation
Signed-off-by: i-curve <i-curve@qq.com>
@microsoft-github-policy-service agree |
Signed-off-by: i-curve <i-curve@qq.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. But somebody else must approve.
@dg0yt thanks for your suggestion. |
Signed-off-by: i-curve <i-curve@qq.com>
Signed-off-by: i-curve <i-curve@qq.com>
@dg0yt Hi, after I change the port file and commit it, git-tree need to change in the version's file. What's the mean git-tree? Am I doing the right thing by git's commit twice? |
You are doing it right. It is just annoying, in particular with PR suggestions, that updating |
Signed-off-by: i-curve <i-curve@qq.com>
Signed-off-by: i-curve <i-curve@qq.com>
Usage test pass on |
find_package
calls are REQUIRED, are satisfied byvcpkg.json
's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxxvcpkg.json
matches what upstream says.vcpkg.json
matches what upstream says../vcpkg x-add-version --all
and committing the result.