Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[copypp] New port #35309 #35310

Merged
merged 8 commits into from
Nov 29, 2023
Merged

[copypp] New port #35309 #35310

merged 8 commits into from
Nov 29, 2023

Conversation

i-curve
Copy link
Contributor

@i-curve i-curve commented Nov 24, 2023

  • Changes comply with the maintainer guide
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@i-curve
Copy link
Contributor Author

i-curve commented Nov 24, 2023

@microsoft-github-policy-service agree

ports/copypp/portfile.cmake Outdated Show resolved Hide resolved
ports/copypp/portfile.cmake Outdated Show resolved Hide resolved
ports/copypp/usage Outdated Show resolved Hide resolved
Copy link
Contributor

@dg0yt dg0yt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But somebody else must approve.

ports/copypp/portfile.cmake Outdated Show resolved Hide resolved
ports/copypp/portfile.cmake Outdated Show resolved Hide resolved
@i-curve
Copy link
Contributor Author

i-curve commented Nov 25, 2023

@dg0yt thanks for your suggestion.

Signed-off-by: i-curve <i-curve@qq.com>
Signed-off-by: i-curve <i-curve@qq.com>
@i-curve
Copy link
Contributor Author

i-curve commented Nov 25, 2023

@dg0yt Hi, after I change the port file and commit it, git-tree need to change in the version's file. What's the mean git-tree? Am I doing the right thing by git's commit twice?

@dg0yt
Copy link
Contributor

dg0yt commented Nov 25, 2023

You are doing it right.
git-tree is an interal git thing refering to the (per-port-dir) filesystem state. You could update the commit message and even other directories (such as updating the records in versions/) without changing the git-tree reference, while the commit SHA changes everytime.
And it makes it possible to squash-merge PRs here.

It is just annoying, in particular with PR suggestions, that updating versions/ isn't automated.

ports/copypp/portfile.cmake Outdated Show resolved Hide resolved
Signed-off-by: i-curve <i-curve@qq.com>
Signed-off-by: i-curve <i-curve@qq.com>
@Adela0814 Adela0814 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Nov 27, 2023
@Adela0814
Copy link
Contributor

Usage test pass on x64-windows and x64-windows-static.

@Adela0814 Adela0814 added the info:reviewed Pull Request changes follow basic guidelines label Nov 27, 2023
@vicroms vicroms merged commit 352d062 into microsoft:master Nov 29, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants