-
Notifications
You must be signed in to change notification settings - Fork 329
fix(openapi3): emit @encode decorator for anyOf/oneOf with unixtime format #9164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rmat
When a property schema uses anyOf/oneOf with a union of {type: "integer", format: "unixtime"} and {type: "null"}, the converter now correctly emits the @encode(DateTimeKnownEncoding.unixTimestamp, integer) decorator along with the utcDateTime | null type.
Co-authored-by: baywet <7905502+baywet@users.noreply.github.com>
Co-authored-by: baywet <7905502+baywet@users.noreply.github.com>
- Remove redundant empty array fallback - Add proper type checking for memberType to handle edge cases - Improve code structure for better null safety Co-authored-by: baywet <7905502+baywet@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix missing decorator for anyOf unixtime in converter
fix(openapi3): emit @encode decorator for anyOf/oneOf with unixtime format
Dec 9, 2025
baywet
approved these changes
Dec 9, 2025
commit: |
.chronus/changes/fix-anyof-unixtime-decorator-2025-12-09-16-54-20.md
Outdated
Show resolved
Hide resolved
timotheeguerin
approved these changes
Dec 9, 2025
…-20.md Co-authored-by: Timothee Guerin <tiguerin@microsoft.com>
Contributor
|
All changed packages have been documented.
Show changes
|
timotheeguerin
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When importing OpenAPI schemas with
anyOf/oneOfcontaining{type: "integer", format: "unixtime"}and{type: "null"}, the converter was dropping the@encode(DateTimeKnownEncoding.unixTimestamp, integer)decorator.Before:
finished_at?: utcDateTime | null // Missing @encode decoratorAfter:
Changes
decorators.ts: ModifiedgetDecoratorsForSchemato extractformatproperty fromanyOf/oneOfmembers when not present at schema rootanyOfandoneOfunion variants with unixtime formatOriginal prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.