-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: @withVisibility
decorator
#2544
Fix: @withVisibility
decorator
#2544
Conversation
Changes in this PR will be published to the following url to try(check status of TypeSpec Pull Request Try It pipeline for publish status): Website: https://tspwebsitepr.z22.web.core.windows.net/prs/2544/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Todo need to update the doc to explain this new behavior
Todo add tests
I think there is still a problem. I believe that any model I define in TypeSpec should appear in the OpenAPI with all the properties I defined in them (in the absence of a "withVisibility" decorator). But this isn't the case, as this playground illustrates. The |
yeah I guess, my fix might actually only really fix the other issue Brian thought about. So this remaining fix I guess is about the openapi3 emitter not using visibility for unreachable models. So the 2 issues are:
|
fix #2517