Handle @captureSuggestions in the harness
#1237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for capturing suggestion diagnostics in the test harness, aligning with the recently introduced @captureSuggestions flag.
- Updates the baseline files to reflect the new suggestion diagnostic counts.
- Inserts a conditional in the harness to append suggestion diagnostics when the flag is enabled.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| testdata/baselines/reference/submodule/compiler/overshifts.errors.txt.diff | Updates baseline diff by removing outdated suggestion diagnostics entries. |
| testdata/baselines/reference/submodule/compiler/overshifts.errors.txt | Refreshes the baseline with the revised error count reflecting suggestion diagnostics. |
| internal/testutil/harnessutil/harnessutil.go | Adds a conditional block to capture and append suggestion diagnostics when enabled. |
jakebailey
approved these changes
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was surprised only a single baseline got updated but it makes sense - this option was introduced somewhat recently, here: microsoft/TypeScript#59519