Merge remote-tracking branch 'upstream/main' into goto-function-name

Author: shinichy

.dprint.jsonc

@@ -41,7 +41,7 @@
         "cwd": "${configDir}",
         "cacheKey": "4",
         "commands": [
-            { "command": "gofumpt -lang=go1.24", "exts": ["go"] }
+            { "command": "go tool mvdan.cc/gofumpt -lang=go1.24", "exts": ["go"] }
         ]
     },
     "excludes": [
@@ -50,17 +50,18 @@
         "**/*-lock.json",
         "**/testdata",
         "_submodules/**",
-        "**/*_generated.go",
         "internal/bundled/libs/**",
         "internal/lsp/lsproto/_generate/*.json",
-        "internal/lsp/lsproto/_generate/metaModelSchema.mts"
+        "internal/lsp/lsproto/_generate/metaModelSchema.mts",
+        // Needs to be LF to have a working shebang.
+        "_packages/native-preview/bin/tsgo.js"
     ],
     // Note: if adding new languages, make sure settings.template.json is updated too.
     // Also, if updating typescript, update the one in package.json.
     "plugins": [
-        "https://plugins.dprint.dev/typescript-0.94.0.wasm",
+        "https://plugins.dprint.dev/typescript-0.95.7.wasm",
         "https://plugins.dprint.dev/json-0.20.0.wasm",
-        "https://plugins.dprint.dev/g-plane/pretty_yaml-v0.5.0.wasm",
+        "https://plugins.dprint.dev/g-plane/pretty_yaml-v0.5.1.wasm",
         "https://plugins.dprint.dev/exec-0.5.1.json@492414e39dea4dccc07b4af796d2f4efdb89e84bae2bd4e1e924c0cc050855bf"
     ]
 }

.github/actions/setup-go/action.yml

@@ -14,7 +14,7 @@ runs:
   steps:
     - name: Install Go
       id: install-go
-      uses: actions/setup-go@0aaccfd150d50ccaeb58ebd88d36e91967a5f35b # v5.4.0
+      uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # v5.5.0
       with:
         go-version: ${{ inputs.go-version }}
         cache: false

.github/copilot-instructions.md

@@ -0,0 +1,85 @@
+This is the codebase for a native port of the TypeScript compiler and language server.
+The source directories of interest that we have are:
+
+- `internal` - Contains the compiler and language server code.
+- `_extension` - Contains a preview VS Code extension code that integrates with the language server.
+- `_submodules/TypeScript` - the stable TypeScript repository, checked out at the appropriate commit.
+
+Most of our development takes place in the `internal` directory, and most behaviors can be tested via compiler tests.
+
+Most development on the codebase is in Go.
+Standard Go commands and practices apply, but we primarily use a tool called `hereby` to build, run tests, and other tasks.
+Feel free to install `hereby` globally (`npm install -g hereby`) if it is easier, and run `hereby --list` to see all available commands.
+
+```sh
+hereby build  # Build the project
+hereby test   # Run tests
+hereby format # Format the code
+hereby lint   # Run linters
+```
+
+Always make sure code is formatted, linted, and tested before sending a pull request.
+
+## Compiler Features, Fixes, and Tests
+
+When fixing a bug or implementing a new feature, at least one minimal test case should always be added in advance to verify the fix.
+This project primarily uses snapshot/baseline/golden tests rather than unit tests.
+New compiler tests are written in `.ts`/`.tsx` files in the directory `testdata/tests/cases/compiler/`, and are written in the following format:
+
+```ts
+// @target: esnext
+// @module: preserve
+// @moduleResolution: bundler
+// @strict: true
+// @checkJs: true
+
+// @filename: fileA.ts
+
+export interface Person {
+    name: string;
+    age: number;
+}
+
+// @filename: fileB.js
+
+/** @import { Person } from "./fileA" */
+
+/**
+* @param {Person} person
+*/
+function greet(person) {
+    console.log(`Hello, ${person.name}!`);
+}
+```
+
+Tests don't always need the above `@option`s specified, but they are common to specify or modify.
+Tests can be run with multiple settings for a given option by using a comma-separated list (e.g. `@option: settingA,settingB`).
+`@filename` is only required when a test has multiple files, or when writing a test for a single JavaScript file (where `allowJs` or `checkJs` is enabled).
+You can see more tests in `_submodules/TypeScript/tests/cases/{compiler,conformance}`.
+
+When tests are run, they will produce output files in the `testdata/baselines/local` directory.
+**Test failures are fine** if they are just differences in output files.
+A reduction/removal of `.diff` file baselines is **ideal** because it indicates the port has converged in behavior with the stable TypeScript codebase.
+The new outputs can be diffed against `testdata/baselines/reference` to see if the output has changed.
+
+Running
+
+```sh
+npx hereby baseline-accept
+```
+
+will update the baselines/snapshots, and `git diff` can be used to see what has changed.
+
+It is ideal to implement features and fixes in the following order, and commit code after each step:
+
+1. Write a minimal test case, or test cases, that demonstrate the bug or feature.   
+1. Run the tests to ensure it fails (for a bug) or passes (for a feature). Then accept generated baselines (not applicable in the case of a crash).
+1. Implement the fix or feature.
+1. Run the tests again to ensure everything is working correctly. Accept the baselines.
+
+It is fine to implement more and more of a feature across commits, but be sure to update baselines every time so that reviewers can measure progress.
+
+# Other Instructions
+
+- Do not add or change existing dependencies unless asked to.
+ 

.github/workflows/ci.yml

@@ -31,6 +31,14 @@ jobs:
         with:
           cache-name: build
 
+      # Avoid duplicate PR annotations.
+      - name: Disable PR annotations
+        run: |
+          echo "::remove-matcher owner=eslint-compact::"
+          echo "::remove-matcher owner=eslint-stylish::"
+          echo "::remove-matcher owner=tsc::"
+          echo "::remove-matcher owner=go::"
+
       - run: npm ci
 
       - run: npx hereby build
@@ -53,6 +61,7 @@ jobs:
         config:
           - os: ubuntu-latest
             coverage: true
+            main: true
           - os: windows-latest
             coverage: true
             skip: ${{ github.event_name == 'merge_group' }}
@@ -106,6 +115,15 @@ jobs:
         with:
           cache-name: test
 
+      # Avoid duplicate PR annotations.
+      - if: ${{ ! matrix.config.main }}
+        name: Disable PR annotations
+        run: |
+          echo "::remove-matcher owner=eslint-compact::"
+          echo "::remove-matcher owner=eslint-stylish::"
+          echo "::remove-matcher owner=tsc::"
+          echo "::remove-matcher owner=go::"
+
       - run: npm ci
 
       - run: go install gotest.tools/gotestsum@latest
@@ -128,7 +146,7 @@ jobs:
 
       - run: git add .
 
-      - uses: codecov/codecov-action@ad3126e916f78f00edff4ed0317cf185271ccc2d # v5.4.2
+      - uses: codecov/codecov-action@18283e04ce6e62d37312384ff67231eb8fd56d24 # v5.4.3
         if: ${{ always() && matrix.config.coverage && github.event_name != 'merge_group' }}
         with:
           use_oidc: ${{ !(github.event_name == 'pull_request' && github.event.pull_request.head.repo.fork) }}
@@ -155,10 +173,12 @@ jobs:
       matrix:
         config:
           - os: ubuntu-latest
+            main: true
           - os: windows-latest
             skip: ${{ github.event_name == 'merge_group' }}
-          - os: macos-latest
-            skip: ${{ github.event_name == 'merge_group' }}
+          # Skip macOS; we do not have any build tag'd files that require checking.
+          # - os: macos-latest
+          #   skip: ${{ github.event_name == 'merge_group' }}
           - os: ubuntu-latest
             name: 'noembed'
             noembed: true
@@ -182,6 +202,15 @@ jobs:
         with:
           cache-name: lint${{ (matrix.config.noembed && '-noembed') || ''}}
 
+      # Avoid duplicate PR annotations.
+      - if: ${{ ! matrix.config.main }}
+        name: Disable PR annotations
+        run: |
+          echo "::remove-matcher owner=eslint-compact::"
+          echo "::remove-matcher owner=eslint-stylish::"
+          echo "::remove-matcher owner=tsc::"
+          echo "::remove-matcher owner=go::"
+
       - run: npm ci
 
       - run: npx hereby lint
@@ -198,7 +227,6 @@ jobs:
 
       - run: npm ci
 
-      - run: npx hereby install-tools
       - run: npx hereby check:format
 
   generate:
@@ -208,6 +236,8 @@ jobs:
         with:
           submodules: true
       - uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
+        with:
+          node-version: '>=22.16.0'
       - uses: dtolnay/rust-toolchain@fcf085fcb4b4b8f63f96906cd713eb52181b5ea4 # stable
       - uses: ./.github/actions/setup-go
         with:
@@ -220,6 +250,12 @@ jobs:
       - run: node ./internal/lsp/lsproto/_generate/fetchModel.mjs
       - run: node ./internal/lsp/lsproto/_generate/generate.mjs
 
+      - name: Remove all converted fourslash tests
+        run: rm -rf internal/fourslash/tests/gen
+
+      - name: Regenerate fourslash tests
+        run: npm run convertfourslash
+
       - run: git add .
       - run: git diff --staged --exit-code --stat
 
@@ -246,6 +282,14 @@ jobs:
         with:
           cache-name: smoke
 
+      # Avoid duplicate PR annotations.
+      - name: Disable PR annotations
+        run: |
+          echo "::remove-matcher owner=eslint-compact::"
+          echo "::remove-matcher owner=eslint-stylish::"
+          echo "::remove-matcher owner=tsc::"
+          echo "::remove-matcher owner=go::"
+
       - run: npm ci
 
       - run: npx hereby build --race

.github/workflows/codeql.yml

@@ -48,7 +48,7 @@ jobs:
 
       # Initializes the CodeQL tools for scanning.
       - name: Initialize CodeQL
-        uses: github/codeql-action/init@45775bd8235c68ba998cffa5171334d58593da47 # v3.28.15
+        uses: github/codeql-action/init@ce28f5bb42b7a9f2c824e633a3f6ee835bab6858 # v3.29.0
         with:
           config-file: ./.github/codeql/codeql-configuration.yml
         # Override language selection by uncommenting this and choosing your languages
@@ -58,7 +58,7 @@ jobs:
       # Autobuild attempts to build any compiled languages (C/C++, C#, or Java).
       # If this step fails, then you should remove it and run the build manually (see below).
       - name: Autobuild
-        uses: github/codeql-action/autobuild@45775bd8235c68ba998cffa5171334d58593da47 # v3.28.15
+        uses: github/codeql-action/autobuild@ce28f5bb42b7a9f2c824e633a3f6ee835bab6858 # v3.29.0
 
       # ℹ️ Command-line programs to run using the OS shell.
       # 📚 See https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsrun
@@ -72,4 +72,4 @@ jobs:
       #     make release
 
       - name: Perform CodeQL Analysis
-        uses: github/codeql-action/analyze@45775bd8235c68ba998cffa5171334d58593da47 # v3.28.15
+        uses: github/codeql-action/analyze@ce28f5bb42b7a9f2c824e633a3f6ee835bab6858 # v3.29.0

.github/workflows/copilot-setup-steps.yml

@@ -0,0 +1,30 @@
+name: 'Copilot Setup Steps'
+
+on: workflow_dispatch
+
+jobs:
+  # The job MUST be called `copilot-setup-steps` or it will not be picked up by Copilot.
+  copilot-setup-steps:
+    runs-on: ubuntu-latest
+
+    # Set the permissions to the lowest permissions possible needed for your steps.
+    # Copilot will be given its own token for its operations.
+    permissions:
+      # If you want to clone the repository as part of your setup steps, for example to install dependencies, you'll need the `contents: read` permission. If you don't clone the repository in your setup steps, Copilot will do this for you automatically after the steps complete.
+      contents: read
+
+    # You can define any steps you want, and they will run before the agent starts.
+    # If you do not check out your code, Copilot will do this for you.
+    steps:
+      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
+        with:
+          submodules: true
+      - uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
+      - uses: dtolnay/rust-toolchain@fcf085fcb4b4b8f63f96906cd713eb52181b5ea4 # stable
+      - uses: ./.github/actions/setup-go
+        with:
+          cache-name: copilot-setup-steps
+      - run: npm i -g @playwright/mcp@0.0.28
+      - run: npm ci
+      # pull dprint caches before network access is blocked
+      - run: npx hereby check:format || true

.gitignore

@@ -194,3 +194,7 @@ custom-gcl.hash
 .idea
 
 !testdata/submoduleAccepted.txt
+
+!NOTICE.txt
+
+!internal/fourslash/_scripts/failingTests.txt

.vscode/launch.template.json

@@ -28,6 +28,26 @@
                 "-test.run",
                 "TestSubmodule/${fileBasename}"
             ]
+        },
+        {
+            "name": "Launch submodule test (with profiling)",
+            "type": "go",
+            "request": "launch",
+            "mode": "test",
+            "program": "${workspaceFolder}/internal/testrunner",
+            "args": [
+                "-test.cpuprofile",
+                "${workspaceFolder}/test.prof",
+                "-test.run",
+                "TestSubmodule/${fileBasename}"
+            ]
+        },
+        {
+            "name": "Launch fourslash test",
+            "type": "go",
+            "request": "launch",
+            "mode": "test",
+            "program": "${workspaceFolder}/internal/fourslash/gen/${fileBasename}"
         }
     ]
 }

.vscode/tasks.json

@@ -17,7 +17,7 @@
         {
             "label": "Watch",
             "type": "npm",
-            "script": "build:watch",
+            "script": "build:watch:debug",
             "group": "build",
             "presentation": {
                 "panel": "dedicated",