Add support for query parameters for POST, PATCH, and PUT requests #301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
And |
|
I'm guessing given the tests working locally and the weird timing that it might have just been a temporal thing that should be fixed by now, could anyone please re-trigger the checks? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that this was only supported for GET and DELETE requests. Given that some APIs do actually support having query parameters for these types, I figured that adding support for them (Given that the update has no conflicting changes) only makes the client more versatile.
My last PR had some problems with some test units failing because of a down link, but this one should be all good.
Fixes #257 and has no breaking changes.