Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove use of ES2015 syntax #275

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Remove use of ES2015 syntax #275

merged 1 commit into from
Oct 31, 2024

Conversation

andrewbranch
Copy link
Member

Fixes #274

jakebailey
jakebailey approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@jakebailey jakebailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like we should add a cjs-module-lexer test just to verify that these work (I did it manually to check too).

@andrewbranch
Copy link
Member Author

https://github.com/microsoft/tslib/blob/main/test/node/exportStructure.test.js

@andrewbranch andrewbranch merged commit 11fa982 into main Oct 31, 2024
3 checks passed
@andrewbranch andrewbranch deleted the bug/es5-compat branch October 31, 2024 22:39
@jakebailey
Copy link
Member

Yeah, missed that 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakebailey jakebailey jakebailey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Version 2.8.0 ES5 Incompatibility
2 participants
@andrewbranch @jakebailey