Support php 8.0 union types for param/property/return #303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid crashing existing applications such as language servers, the existing typeDeclaration properties continue to be of type Node|Token. An additional otherTypeDeclarations property was added to support union types. Normally, it will either be null, or contain alternating BarTokens and nodes/tokens for types. Add various tests of union types in parameters, properties, and return types. Fixes microsoft#302
Contributor
Author
|
@roblourens - This is ready for another look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid crashing existing applications such as language servers,
the existing typeDeclaration properties continue to be of type
Node|Token.
An additional otherTypeDeclarations property was added to support union
types. Normally, it will either be null, or contain alternating
BarTokens and nodes/tokens for types.
Add various tests of union types in parameters, properties, and return
types.
Fixes #302