For #19: Fix an edge case parsing = and instanceof
#228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does not fix every single edge case. This only fixes the edge cases for unary operators on the left hand side of binary operators expecting a variable. (That probably isn't even every single binary operator or unary operator)
Contributor
Author
|
Is there anything that needs to be addressed for this or PR 232? |
Member
|
Thanks for the PRs! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not fix every single edge case.
This only fixes the edge cases for unary operators
on the left hand side of binary operators expecting a variable.
if (!$x = expr())is something I've seen frequently, which is why I'm fixing this here. A complete fix would probably be more complex (e.g. deeply nested binary operators)(That probably isn't even every single binary operator or unary operator)
See #19 (comment) and #19 (comment)