Can't parse names that are reserved words

[roblourens]

felixfbecker/php-language-server#448

A namespace named object is ok, even though it's a reserved word: http://php.net/manual/en/reserved.other-reserved-words.php

It's a "soft reserved" word - but it even seems that reserved words like 'int' are ok as names in PHP?

[jens1o]

It's a "soft reserved" word - but it even seems that reserved words like 'int' are ok as names in PHP?

No, there not since PHP 7, for example Int as a classname, must be rewritten to Int_.
See nikic/PHP-Parser@1a62787

As of PHP 7.2, the same is true for object in names.

[TysonAndre]

A related issue: This can't parse boolean as a parameter name. (It can show up in a type cast, but isn't a hard/soft reserved word)

An example is attempting to parse <?php function test(boolean $x){}

php dump.php 'function test(boolean $x){}' 
Node\SourceFileNode
    statementList: Node\Statement\FunctionDeclaration
        functionKeyword: Token: FunctionKeyword(134): "function"
        name: Token: Name(2): " test"
        openParen: Token: OpenParenToken(203): "("
        closeParen: MissingToken: CloseParenToken(204): ""
        compoundStatementOrSemicolon: Node\Statement\CompoundStatementNode
            openBrace: MissingToken: OpenBraceToken(205): ""
            statements: Node\Statement\ExpressionStatement
                expression: Node\QualifiedName
                    nameParts: Token: Name(2): "boolean"
                semicolon: MissingToken: SemicolonToken(237): ""   <---- unexpected MissingToken
            statements: Node\Statement\ExpressionStatement
                expression: Node\Expression\Variable
                    name: Token: VariableName(3): " $x"
                semicolon: MissingToken: SemicolonToken(237): ""
            statements: SkippedToken: CloseParenToken(204): ")"
            statements: Node\Statement\CompoundStatementNode
                openBrace: Token: OpenBraceToken(205): "{"
                closeBrace: Token: CloseBraceToken(206): "}"
            closeBrace: MissingToken: CloseBraceToken(206): ""
    endOfFileToken: Token: EndOfFileToken(1): ""