Fix Assert.That to not evaluate expression twice #6699
+527
−99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Youssef1313
reviewed
Oct 8, 2025
| public static partial class AssertExtensions | ||
| { | ||
| // Constants for standardized display values | ||
| private const string FailedToEvaluate = "<Failed to evaluate>"; |
There was a problem hiding this comment.
Do we want this to be localized?
There was a problem hiding this comment.
Fine by me. FYI it wasn't localized before.
Evangelink
commented
Oct 8, 2025
…soft/testfx into dev/amauryleve/assert-that
nohwnd
reviewed
Oct 8, 2025
| } | ||
|
|
||
| // Fallback - this should not happen if EvaluateAllSubExpressions works correctly | ||
| return false; |
There was a problem hiding this comment.
Consider throwing here if we should not reach it.
| .WithMessage(""" | ||
| Assert.That(() => box.GetNumber() + box.GetNumber() == 0) failed. | ||
| Details: | ||
| box.GetNumber() = 1 |
There was a problem hiding this comment.
This test passes but imho should not, we get no information about the second call to box.GetNumber, leaving us stumped why it failed. Especially if we use expected = 1, not super easy to debug :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6690