From 80b813d36bd3dbd6db058fd6505efbff5bb70bf6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Amaury=20Lev=C3=A9?= <amauryleve@microsoft.com>
Date: Fri, 16 Feb 2024 09:22:20 +0100
Subject: [PATCH] Workaround harmless MSBuild warning in VS (#2350)

---
 src/Adapter/Build/Common/MSTest.TestAdapter.targets | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/src/Adapter/Build/Common/MSTest.TestAdapter.targets b/src/Adapter/Build/Common/MSTest.TestAdapter.targets
index 24258f307e..da96212c26 100644
--- a/src/Adapter/Build/Common/MSTest.TestAdapter.targets
+++ b/src/Adapter/Build/Common/MSTest.TestAdapter.targets
@@ -31,9 +31,20 @@
       (i.e. `<None Remove="@(TestAdapterContent)" />`)
       -->
     <None Include="@(TestAdapterContent)" />
-    <Reference Include="Microsoft.VisualStudio.TestPlatform.MSTest.TestAdapter" HintPath="$(MSBuildThisFileDirectory)Microsoft.VisualStudio.TestPlatform.MSTest.TestAdapter.dll" Condition=" '$(EnableMSTestRunner)' == 'true' " />
   </ItemGroup>
 
+  <Choose>
+    <!-- Avoid false warning about missing reference (msbuild bug) -->
+    <!-- https://github.com/dotnet/msbuild/issues/9698#issuecomment-1945763467 -->
+    <When Condition=" '$(EnableMSTestRunner)' == 'true' ">
+      <ItemGroup>
+        <Reference Include="Microsoft.VisualStudio.TestPlatform.MSTest.TestAdapter">
+          <HintPath>$(MSBuildThisFileDirectory)Microsoft.VisualStudio.TestPlatform.MSTest.TestAdapter.dll</HintPath>
+        </Reference>
+      </ItemGroup>
+    </When>
+  </Choose>
+
   <Target Name="GetMSTestV2CultureHierarchy">
     <!--
       Only traversing 5 levels in the culture hierarchy. This is the maximum length for all cultures and should be sufficient