Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncontrastive start bar icon #5589

Open
vadimkantorov opened this issue Apr 27, 2020 · 5 comments
Open

Uncontrastive start bar icon #5589

vadimkantorov opened this issue Apr 27, 2020 · 5 comments
Assignees
Labels
Area-Accessibility Issues related to accessibility Issue-Question For questions or discussion Product-Terminal The new Windows Terminal.
Milestone

Comments

@vadimkantorov
Copy link

vadimkantorov commented Apr 27, 2020

Chrome, Paint, Explorer, Telegram have more contrastive icon edges, Black on dark blue is makes quite uncontrastive icon edges, especially the left and bottom borders.

image
left - default, right - with mouse hover over

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Apr 27, 2020
@mdtauk
Copy link

mdtauk commented Apr 27, 2020

Should there be an inverted version of the icon, for use with Dark Mode Windows Theme?

@zadjii-msft
Copy link
Member

@vadimkantorov could you share what the Chrome, Paint taskbar icons look like for you? On my machine, the Terminal taskbar icons are behaving the same as the icons for other windows:

Here I've got paint.exe focused:
image

Here, I've got Teams focused, and I'm hovering on the Terminal Icon:
image

and here I've got just the Terminal focused:
image

@zadjii-msft zadjii-msft added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Product-Terminal The new Windows Terminal. labels Apr 27, 2020
@mdtauk
Copy link

mdtauk commented Apr 27, 2020

@vadimkantorov could you share what the Chrome, Paint taskbar icons look like for you? On my machine, the Terminal taskbar icons are behaving the same as the icons for other windows:

I don't think he is saying that it is behaving differently, but that the dark icon doesn't stand out as well as a coloured or brighter icon would.

@vadimkantorov
Copy link
Author

vadimkantorov commented Apr 27, 2020

image

Yes, the dark icon (on already dark start bar background) without clear edges or shadows to highlight edges is almost blurs into background but makes an impresion that this is not intentional (e.g. compare with OpenVPN icon). Tux icon of wsltty also suffers from this, but at least Tux has a lot of yellow/orange, so the problem isn't as bad.

@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Apr 27, 2020
@DHowett-MSFT DHowett-MSFT added Area-Accessibility Issues related to accessibility Issue-Question For questions or discussion labels May 1, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label May 1, 2020
@DHowett-MSFT DHowett-MSFT removed Needs-Attention The core contributors need to come back around and look at this ASAP. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels May 1, 2020
@DHowett-MSFT DHowett-MSFT added this to the Terminal Backlog milestone May 1, 2020
@zadjii-msft zadjii-msft modified the milestones: Terminal Backlog, Backlog Jan 4, 2022
@vadimkantorov
Copy link
Author

vadimkantorov commented Apr 11, 2022

In Win11 + systemwide dark mode the task bar icon is still not contrastive enough. Maybe there needs to be a different icon for dark mode. It simply seems to turn out bad when the icon itself contains a lot of black color. Then it gets lost on the black background of dark mode task bar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Accessibility Issues related to accessibility Issue-Question For questions or discussion Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

5 participants